Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

implement bitfield distribution subsystem #1368

Merged
montekki merged 47 commits into from
Jul 23, 2020
Merged

implement bitfield distribution subsystem #1368

montekki merged 47 commits into from
Jul 23, 2020

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Jul 7, 2020

Ref #1238

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jul 7, 2020
@drahnr drahnr marked this pull request as draft July 7, 2020 09:43
@drahnr drahnr force-pushed the bernhard-bitfield-distribution-1238 branch from 9e15aa9 to 4386c7e Compare July 7, 2020 10:44
@drahnr drahnr added A3-in_progress Pull request is in progress. No review needed at this stage. C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. labels Jul 7, 2020
@drahnr drahnr self-assigned this Jul 8, 2020
@drahnr drahnr changed the title bitfield distribution implement bitfield distribution subsystem Jul 8, 2020
@drahnr drahnr force-pushed the bernhard-bitfield-distribution-1238 branch 2 times, most recently from 5f7656c to a2e8bc2 Compare July 10, 2020 16:08
@drahnr drahnr force-pushed the bernhard-bitfield-distribution-1238 branch from 9a7cb2d to 4c6f9b4 Compare July 14, 2020 15:06
@drahnr drahnr added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jul 14, 2020
rphmeier
rphmeier reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, code looks clean and logic seems correct on-the-whole. Would like to see a couple more tests, esp. on things that came up in review.

@rphmeier rphmeier added A5-grumble and removed A0-please_review Pull request needs code review. labels Jul 22, 2020
rphmeier
rphmeier reviewed Jul 22, 2020
View reviewed changes
rphmeier
rphmeier reviewed Jul 22, 2020
View reviewed changes
ordian
ordian reviewed Jul 22, 2020
View reviewed changes
ordian
ordian reviewed Jul 22, 2020
View reviewed changes
@drahnr drahnr requested a review from rphmeier July 22, 2020 14:22
@drahnr drahnr added A0-please_review Pull request needs code review. and removed A5-grumble labels Jul 22, 2020
@rphmeier rphmeier added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Jul 22, 2020
@rphmeier
Copy link
Contributor

rphmeier commented Jul 22, 2020

The CI is failing (warnings need to be fixed). After that it should be mergeable.

@coriolinus coriolinus added the B0-silent Changes should not be mentioned in any release notes label Jul 23, 2020
@montekki montekki merged commit 08fcbda into master Jul 23, 2020
@montekki montekki deleted the bernhard-bitfield-distribution-1238 branch July 23, 2020 12:46
@drahnr drahnr mentioned this pull request Sep 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coriolinus coriolinus Awaiting requested review from coriolinus

2 more reviewers

@ordian ordian ordian left review comments

@rphmeier rphmeier rphmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drahnr drahnr

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement: Bitfield Distribution

6 participants

@drahnr @rphmeier @ordian @coriolinus @montekki