Change DmpAlg to use preallocated arrays

[calewis]

DmpAlg isn't called with nr_order_ > 3 so this change saves 9 news and 9 frees for each construction and destruction of the class.

[CLAassistant]

All committers have signed the CLA.

[calewis]

Not sure how OpenSTA usually checks things like this. Let me know and I'll update it to the preferred method.

[jjcherry56]

Never with assert (tag search or grep for assert and you will see that yourself). You can answer your own question by reading the other code in the same file. As an exercise I want you to explain why the check is not necessary.

[calewis]

Thanks for the feedback. I've changed the function to throw a DmpError if the order is greater than max_nr_order_. I've taken another look at the code, and I'm still having trouble seeing what makes the check unnecessary.

[jjcherry56]

If you want a project I would not stop there if I was working on this (I wrote this 25 years ago).
I would make dmp_cap_, dmp_pi_, dmp_zero_c2_ member objects instead of heap allocated.
The next (harder) step would be to move the arrays to the DmpCeff class so they are shared instead
of having 3 copies of them.

But this PR is simple enough to use as a first step.

[jjcherry56]

Look at the DmpAlg constructor calls

[calewis]

I'm aware that DmpAlg is currently not called with any nr_order above 3. But If someone did change to call it with a larger number I think they'd appreciate the error message instead of the issues they'd get writing/reading past the end of their data.

[calewis]

@jjcherry56 is the check the only thing you'd liked changed? I'd prefer to keep it, but I'll remove it if that's your only objection.