Fix: unreachable code typo#56
Merged
paragonie-security merged 1 commit intoparagonie:masterfrom May 8, 2024
Merged
Conversation
Contributor
Author
|
Probably that second check could have been just removed, it does not give anything substantial. Thats why this bug was not noticed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Base64->decodeNoPadding()two conditional checks of$srcLen & 3. But it can't be zero and greater than 1 at the same time, probably that was a typo. As far as I can understand, this is just a check for padding characters in last two places, so second condition was meant as$strLen > 1. But its always true: in previous code it was checked to be not zero, and then checked for$srcLen & 3(basically "is it divisible by 4?"), so it cant be less than 4 in this branch.So, I've done light refactoring of this place. Since its an input validation, it should not leak any significant information in context of timing attacks.