feat: make js-tracer feature optional for node builder crate

[edisontim]

Closes #11548

[mattsse]

need some clarification on the issue first to proceed here

[mattsse]

this should go above test-utils

[mattsse]

we also need to enable this in the node crates for ethereum and optimism to actually enable this:

reth/crates/optimism/node/Cargo.toml

Line 23 in 129f3ba

reth-node-builder.workspace = true

reth/crates/ethereum/node/Cargo.toml

Line 19 in 129f3ba

reth-node-builder.workspace = true

[edisontim]

we also need to enable this in the node crates for ethereum and optimism to actually enable this:

reth/crates/optimism/node/Cargo.toml

Line 23 in 129f3ba

reth-node-builder.workspace = true

reth/crates/ethereum/node/Cargo.toml

Line 19 in 129f3ba

reth-node-builder.workspace = true

Sure! Should I make this a default or also make it as a feature in optimism and eth crate?
reth-node-builder = { workspace = true, features = ["js-tracer"] }
or

js-tracer = [
	"reth-node-builder/js-tracer"
]

[storopoli]

we also need to enable this in the node crates for ethereum and optimism to actually enable this:

reth/crates/optimism/node/Cargo.toml

Line 23 in 129f3ba

reth-node-builder.workspace = true

reth/crates/ethereum/node/Cargo.toml

Line 19 in 129f3ba

reth-node-builder.workspace = true

Sure! Should I make this a default or also make it as a feature in optimism and eth crate? reth-node-builder = { workspace = true, features = ["js-tracer"] } or

js-tracer = [
	"reth-node-builder/js-tracer"
]

If possible make it all a feature and opt-in.
The boa machinery should, in my humble opinion, be opt-in.
It really increases the compile time for users and also for everything that it encompasses such as CI for example.

[delbonis]

I'm also needing this. This should be opt-in, at the very least because (as it is right now) it makes API consumer have to build the whole JS engine even when they don't use it. I don't know if there's some issue with the crate hierarchy that makes the exposing the types in the API necessitate building the engine crates, that seems strange.

[edisontim]

Hey @mattsse, i think this is ready for review if you could have a look :)

[mattsse]

I don't know if there's some issue with the crate hierarchy that makes the exposing the types in the API necessitate building the engine crates, that seems strange.

could please elaborate, which crates exactly @delbonis

[mattsse]

this still removes js-tracer support from the binary because now it is no longer enabled.

we either need this for ethereum node and optimism node by default or must enable this in the binary.

[edisontim]

this still removes js-tracer support from the binary because now it is no longer enabled.

we either need this for ethereum node and optimism node by default or must enable this in the binary.

Done !

[mattsse]

we also n

[mattsse]

we need this for the optimimism/bin as well

[edisontim]

My bad, I've added it as well in there

[storopoli]

friendly bump 😄

[mattsse]

thanks, wrapping up here now

[storopoli]

Merge is blocked, we need an approval.

[storopoli]

Nice thanks! :)
When does reth releases a new version?