Issue #1993: Feature Request - Add SVG export option to link images and define them in the defs #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k them with a use tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request adds support for linking multiple images to a single source. This addresses the issue with image data duplication in the href attribute when the same image is used multiple times. The standard functionality for the
exportSVGfunction does not change unless the optionlinkImagesis provided.See Issue #1993 for more details
Let me know if you have any feedback, and I can make those changes.
Thanks for all of your work on the project. It has been a great tool that we have used for a long time.
I'm also going to do a bit of full integration testing on our site that uses this to make sure everything is working as expected.We have been using this in production for a bit over a month without an issue.
Related issues
Checklist
yarn run jshintpasses)