Skip to content

CI: Remove ASAN job #57886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 19, 2024
Merged

CI: Remove ASAN job #57886

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
31ad407
Try removing subprocess call in conftest
WillAyd Mar 18, 2024
7f50043
empty bytes
WillAyd Mar 18, 2024
2f9316d
try non-editable
WillAyd Mar 18, 2024
08213d3
Revert "try non-editable"
WillAyd Mar 18, 2024
e4ea69e
Revert "empty bytes"
WillAyd Mar 18, 2024
261d234
Revert "Try removing subprocess call in conftest"
WillAyd Mar 18, 2024
398e19f
Remove ASAN job
WillAyd Mar 18, 2024
1aecf56
Merge remote-tracking branch 'upstream/main' into try-asan-debug
WillAyd Mar 19, 2024
9b8dd85
revert more
WillAyd Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@ jobs:
- name: "Pyarrow Nightly"
env_file: actions-311-pyarrownightly.yaml
pattern: "not slow and not network and not single_cpu"
- name: "ASAN / UBSAN"
env_file: actions-311-sanitizers.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove this file too?

pattern: "not slow and not network and not single_cpu and not skip_ubsan"
asan_options: "ASAN_OPTIONS=detect_leaks=0"
Copy link
Member

@mroeschke mroeschke Mar 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove these extra GHA args in this file/other files as well that are only used for this job too?

preload: LD_PRELOAD=$(gcc -print-file-name=libasan.so)
meson_args: --config-settings=setup-args="-Db_sanitize=address,undefined"
cflags_adds: -fno-sanitize-recover=all
pytest_workers: -1 # disable pytest-xdist as it swallows stderr from ASAN
fail-fast: false
name: ${{ matrix.name || format('ubuntu-latest {0}', matrix.env_file) }}
env:
Expand Down