Skip to content

TST: slow pivot_table test #56042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2023
Merged

TST: slow pivot_table test #56042

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f941465
loop inside test
lukemanley Nov 18, 2023
0af0b9b
construct expected frame
lukemanley Nov 18, 2023
2392fba
update monthly test as well
lukemanley Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions pandas/tests/reshape/test_pivot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1712,8 +1712,7 @@ def test_pivot_dtaccessor(self):
)
tm.assert_frame_equal(result, expected)

@pytest.mark.parametrize("i", range(1, 367))
def test_daily(self, i):
def test_daily(self):
rng = date_range("1/1/2000", "12/31/2004", freq="D")
ts = Series(np.random.default_rng(2).standard_normal(len(rng)), index=rng)

Expand All @@ -1724,12 +1723,12 @@ def test_daily(self, i):

doy = np.asarray(ts.index.dayofyear)

subset = ts[doy == i]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it may be a better test to use tm.assert_frame_equal and compare this to an expected DataFrame (making the input have constant data)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that makes sense. updated

subset.index = subset.index.year

result = annual[i].dropna()
tm.assert_series_equal(result, subset, check_names=False)
assert result.name == i
for i in range(1, 367):
subset = ts[doy == i]
subset.index = subset.index.year
result = annual[i].dropna()
tm.assert_series_equal(result, subset, check_names=False)
assert result.name == i

@pytest.mark.parametrize("i", range(1, 13))
def test_monthly(self, i):
Expand Down