Skip to content

Updated future warning msg in transform() for Series.groupby #55082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Updated future warning msg in transform() for Series.groupby #55082

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab16c7
updated warn msg
rsm-23 Sep 10, 2023
1ca79c7
Update apply.py
rsm-23 Sep 11, 2023
dcf83d4
Merge branch 'main' into warning-update
rsm-23 Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,12 +1832,12 @@ def warn_alias_replacement(
full_alias = alias
else:
full_alias = f"{type(obj).__name__}.{alias}"
alias = f"'{alias}'"
alias = f'`"{alias}"`'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to remove the `s as they might not always render like markdown for example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @mroeschke

warnings.warn(
f"The provided callable {func} is currently using "
f"{full_alias}. In a future version of pandas, "
f"the provided callable will be used directly. To keep current "
f"behavior pass {alias} instead.",
f"behavior pass the string {alias} instead.",
category=FutureWarning,
stacklevel=find_stack_level(),
)