REGR: groupby fails with nullable dtypes and dropna=False #48824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Groupby
Regression
mroeschke
reviewed
Sep 28, 2022
mroeschke
reviewed
Sep 28, 2022
mroeschke
reviewed
Sep 28, 2022
|
Thanks @mroeschke - I was able to simplify this a bit (namely - remove an xfail, less parameters for determining sequence, less repetition of uniques). Also added back in |
|
Looks better. There's still a bit to grok to understand |
mroeschke
approved these changes
Sep 29, 2022
|
Thanks @rhshadrach |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 4, 2022
…s and dropna=False
phofl
pushed a commit
that referenced
this pull request
Oct 5, 2022
… dtypes and dropna=False) (#48938) Backport PR #48824: REGR: groupby fails with nullable dtypes and dropna=False Co-authored-by: Richard Shadrach <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…#48824) * REGR: groupby fails with nullable dtypes and dropna=False * Rework test * Merge cleanup * Range fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This reworked test is a bit ghastly, any suggestions on how to simplify or clean up are most welcome.