Skip to content

BUG: still emitting unnecessary FutureWarning in DataFrame.sort_values with sparse columns #48785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2022
Merged

BUG: still emitting unnecessary FutureWarning in DataFrame.sort_values with sparse columns #48785

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167d60c
BUG: still emitting unnecessary FutureWarning in DataFrame.sort_value…
Sep 26, 2022
975790d
Merge remote-tracking branch 'upstream/main' into overly-eager-sparse…
Sep 27, 2022
2357887
make whatsnew consistent
Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Bug fixes
~~~~~~~~~
- Bug in :meth:`DataFrame.to_hdf` raising ``AssertionError`` with boolean index (:issue:`48667`)
- Bug in :meth:`DataFrame.pivot_table` raising unexpected ``FutureWarning`` when setting datetime column as index (:issue:`48683`)
- Stopped emitting unnecessary ``FutureWarning`` in :meth:`DataFrame.sort_values` with boolean sparse columns (:issue:`48784`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the pattern:

Bug in ... emitting unnecessary...

otherwise lgtm

-

.. ---------------------------------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion pandas/core/sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,9 @@ def lexsort_indexer(
with warnings.catch_warnings():
# TODO(2.0): unnecessary once deprecation is enforced
# GH#45618 don't issue warning user can't do anything about
warnings.filterwarnings("ignore", ".*SparseArray.*", category=FutureWarning)
warnings.filterwarnings(
"ignore", ".*(SparseArray|SparseDtype).*", category=FutureWarning
)

cat = Categorical(k, ordered=True)

Expand Down
5 changes: 3 additions & 2 deletions pandas/tests/frame/methods/test_sort_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@


class TestDataFrameSortValues:
def test_sort_values_sparse_no_warning(self):
@pytest.mark.parametrize("dtype", [np.uint8, bool])
def test_sort_values_sparse_no_warning(self, dtype):
# GH#45618
# TODO(2.0): test will be unnecessary
ser = pd.Series(Categorical(["a", "b", "a"], categories=["a", "b", "c"]))
df = pd.get_dummies(ser, sparse=True)
df = pd.get_dummies(ser, dtype=dtype, sparse=True)

with tm.assert_produces_warning(None):
# No warnings about constructing Index from SparseArray
Expand Down