Skip to content

TST: added test for ea dtypes conversion to datetimetzdtype (GH37553) #43270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2021
Merged

TST: added test for ea dtypes conversion to datetimetzdtype (GH37553) #43270

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b5def4
TST: added test for ea dtypes conversion to datetimetzdtype
lorenzophys Aug 28, 2021
3391499
TST: code review, moved test in the right location, changed assert me…
lorenzophys Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions pandas/tests/frame/methods/test_astype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,38 @@ def test_astype_noncontiguous(self, index_slice):
expected = df.iloc[index_slice]
tm.assert_frame_equal(result, expected, check_dtype=False)

@pytest.mark.parametrize(
"dtype",
tm.ALL_INT_EA_DTYPES + tm.FLOAT_EA_DTYPES,
)
def test_astype_ea_to_datetimetzdtype(self, dtype):
# GH37553
result = Series([4, 0, 9], dtype=dtype).astype(DatetimeTZDtype(tz="US/Pacific"))
expected = Series(
{
0: Timestamp("1969-12-31 16:00:00.000000004-08:00", tz="US/Pacific"),
1: Timestamp("1969-12-31 16:00:00.000000000-08:00", tz="US/Pacific"),
2: Timestamp("1969-12-31 16:00:00.000000009-08:00", tz="US/Pacific"),
}
)

if dtype in tm.FLOAT_EA_DTYPES:
expected = Series(
{
0: Timestamp(
"1970-01-01 00:00:00.000000004-08:00", tz="US/Pacific"
),
1: Timestamp(
"1970-01-01 00:00:00.000000000-08:00", tz="US/Pacific"
),
2: Timestamp(
"1970-01-01 00:00:00.000000009-08:00", tz="US/Pacific"
),
}
)

tm.assert_equal(result, expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If just comparing Series, could use tm.assert_series_equal. assert_equal is useful when doing something like parameterizing over DataFrame and Series (like with the frame_or_series fixture)



class TestAstypeCategorical:
def test_astype_from_categorical3(self):
Expand Down