Skip to content

Conversation

mikeronayne
Copy link
Contributor

@mikeronayne mikeronayne commented Apr 12, 2021

@pep8speaks
Copy link

pep8speaks commented Apr 12, 2021

Hello @mikeronayne! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-16 00:29:08 UTC

@mikeronayne mikeronayne marked this pull request as ready for review April 13, 2021 00:13
@jreback jreback added the Output-Formatting __repr__ of pandas objects, to_string label Apr 13, 2021
@jreback jreback added this to the 1.3 milestone Apr 13, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. small comment, ping on green.

@jreback jreback merged commit 526d52f into pandas-dev:master Apr 16, 2021
@jreback
Copy link
Contributor

jreback commented Apr 16, 2021

thanks @mikeronayne very nice!

yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_string with index=False incorrectly shifts truncation (ellipsis) column
3 participants