Skip to content

PERF: BlockPlacement construction #40227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 6, 2021
Merged

PERF: BlockPlacement construction #40227

merged 9 commits into from
Mar 6, 2021

Conversation

jbrockmendel
Copy link
Member

xref #40171 (comment) when disabling fast_apply, this cuts the linked benchmark by 13%

jbrockmendel
jbrockmendel commented Mar 4, 2021
View reviewed changes
pandas/core/indexes/range.py
@@ -164,7 +164,7 @@ def _simple_new(cls, values: range, name: Hashable = None) -> RangeIndex:
assert isinstance(values, range)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonjayhawkins are the mypy checks thorough/reliable enough that we can safely remove these assertions?

@jbrockmendel jbrockmendel mentioned this pull request Mar 5, 2021
Merged
@jreback jreback added the Internals Related to non-user accessible pandas implementation label Mar 5, 2021
@jreback jreback added this to the 1.3 milestone Mar 5, 2021
@jreback jreback added the Performance Memory or execution speed performance label Mar 5, 2021
@jbrockmendel
Copy link
Member Author

updated with an implementation of BlockManager._simple_new that brings the benchmark gains to 19-22%

@jreback
Copy link
Contributor

jreback commented Mar 5, 2021

pandas/core/internals/managers.py:817: error: Argument 1 to "_simple_new" of "BlockManager" has incompatible type "Tuple[Any, ...]"; expected "Tuple[Block]" [arg-type]

@jbrockmendel
Copy link
Member Author

pandas/core/internals/managers.py:817: error: Argument 1 to "_simple_new" of "BlockManager" has incompatible type "Tuple[Any, ...]"; expected "Tuple[Block]" [arg-type]

addressed + greenish

@jreback
Copy link
Contributor

jreback commented Mar 6, 2021

the numpy_dev failure could be related

@jbrockmendel
Copy link
Member Author

the numpy_dev failure could be related

im pretty sure that is from #39953 (joris commented on it and im assuming he was correct)

@jreback
Copy link
Contributor

jreback commented Mar 6, 2021

ok cool

@jreback jreback merged commit 2e7e3e2 into pandas-dev:master Mar 6, 2021
@jbrockmendel jbrockmendel deleted the perf-internals branch March 6, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Performance Memory or execution speed performance
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback