Skip to content

Removed unused strict struct member in tokenizer #38348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

Removed unused strict struct member in tokenizer #38348

merged 1 commit into from
Dec 8, 2020

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Dec 7, 2020

I don't see where this would ever be assigned a value

jbrockmendel
jbrockmendel approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added IO CSV read_csv, to_csv Clean labels Dec 8, 2020
@jreback jreback added this to the 1.3 milestone Dec 8, 2020
@jreback
Copy link
Contributor

jreback commented Dec 8, 2020

cc @gfyoung

we don't have any tests that hit this ?

gfyoung
gfyoung approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @WillAyd! LGTM.

@jreback - given that the strict attribute is hard-coded to 0, the branch being deleted looks dead, so none of our tests would have been able to hit it.

@jreback jreback merged commit 9534c26 into pandas-dev:master Dec 8, 2020
@jreback
Copy link
Contributor

jreback commented Dec 8, 2020

thanks @WillAyd

@WillAyd WillAyd deleted the tokenizer-cleanup branch April 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

+1 more reviewer

@gfyoung gfyoung gfyoung approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Clean IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@WillAyd @jreback @jbrockmendel @gfyoung