Skip to content

Conversation

kandersolar
Copy link
Contributor

@kandersolar kandersolar commented Jan 31, 2020

First pandas PR, happy to make changes as needed. Is a whatsnew entry needed? And if so, I assume it should go in v1.0.1.rst?

@kandersolar
Copy link
Contributor Author

Thanks @MarcoGorelli for the guidance! Is there anything else I can improve?

@kandersolar
Copy link
Contributor Author

Docs build fail seems unrelated, transient network error? https://github.com/pandas-dev/pandas/pull/31511/checks?check_run_id=419939179#step:6:37

@charlesdong1991
Copy link
Member

@kanderso-nrel likely a network issue, you could add a whatsnew note in 1.1 and try it again

@charlesdong1991 charlesdong1991 added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 31, 2020
@jreback jreback added the Timezones Timezone data dtype label Feb 2, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some comments, pls merge master. ping on green.

@kandersolar
Copy link
Contributor Author

@jreback all green after #31594

@jreback jreback added this to the 1.1 milestone Feb 3, 2020
@jreback jreback merged commit 64336ff into pandas-dev:master Feb 3, 2020
@jreback
Copy link
Contributor

jreback commented Feb 3, 2020

thanks!

@kandersolar kandersolar deleted the reindex_tzaware branch March 10, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning while reindexing tz aware index with method='nearest'
4 participants