Skip to content

CI: Fix Flakey GBQ Tests #30630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 3, 2020
Merged

CI: Fix Flakey GBQ Tests #30630

Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3e124a2
Fixtures for GBQ Tests
alimcmaster1 Dec 26, 2019
51f5171
Fix import
alimcmaster1 Dec 26, 2019
e69f9a1
Update as per comments
alimcmaster1 Dec 26, 2019
d266ca0
Update doc
alimcmaster1 Dec 26, 2019
add8e88
Remove xfail
alimcmaster1 Dec 26, 2019
011fbaf
Merge master
alimcmaster1 Dec 26, 2019
59a9dcd
Table name must be alphanumeric
alimcmaster1 Dec 26, 2019
f4ecffb
Put expectation on correct to_gbq call
alimcmaster1 Dec 26, 2019
3bf5aed
Merge remote-tracking branch 'remotes/upstream/master' into mcmali-fi…
alimcmaster1 Jan 2, 2020
c4a9830
Don't Error if Dataset Exists
alimcmaster1 Jan 2, 2020
5e94956
Teardown tables
alimcmaster1 Jan 2, 2020
a91b8a3
Give dataset random name
alimcmaster1 Jan 2, 2020
7687d43
Make func module level
alimcmaster1 Jan 3, 2020
ceef3f6
Make func module level
alimcmaster1 Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pandas/tests/io/test_gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,25 +147,25 @@ def mock_read_gbq(sql, **kwargs):

@pytest.mark.single
class TestToGBQIntegrationWithServiceAccountKeyPath:
@staticmethod
def generate_rand_str(length: int = 10) -> str:
return "".join(random.choices(string.ascii_lowercase, k=length))

@pytest.fixture()
def gbq_dataset(self):
# Setup Dataset
_skip_if_no_project_id()
_skip_if_no_private_key_path()

dataset_id = "pydata_pandas_bq_testing_py31"
dataset_id = "pydata_pandas_bq_testing_" + self.generate_rand_str()

self.client = _get_client()
self.dataset = self.client.dataset(dataset_id)
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, are we supposed to clean up these datasets? @tswast

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now just do this here:

pandas/pandas/tests/io/test_gbq.py

Line 173 in a91b8a3

self.client.delete_dataset(self.dataset, delete_contents=True)

# Clean-up previous test runs.
self.client.delete_dataset(self.dataset, delete_contents=True)
except api_exceptions.NotFound:
pass # It's OK if the dataset doesn't already exist.

# Create the dataset
self.client.create_dataset(bigquery.Dataset(self.dataset))

table_name = "".join(random.choices(string.ascii_lowercase, k=10))
table_name = self.generate_rand_str()
destination_table = f"{dataset_id}.{table_name}"
yield destination_table

Expand Down