Skip to content

Performance of maybe_box_datetimelike #30520 #30531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Performance of maybe_box_datetimelike #30520 #30531

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
74f4b8b
Issue #30520
ivan-vasilev Dec 28, 2019
dcb45ed
Issue #30520
ivan-vasilev Dec 28, 2019
6a2511c
Issue #30520 works for timedeltas as well
ivan-vasilev Dec 28, 2019
54cb25e
Issue #30520 check for NaT values
ivan-vasilev Dec 29, 2019
9d751b9
new lines using parentheses
ivan-vasilev Dec 29, 2019
524150c
Issue #30520 more readable code + specifically check for NaT
ivan-vasilev Dec 29, 2019
c9699d9
code formatting
ivan-vasilev Dec 29, 2019
65ab964
code formatting
ivan-vasilev Dec 29, 2019
48cc580
first attempt at ASV performance test
ivan-vasilev Dec 30, 2019
81d66b0
import sorting fix
ivan-vasilev Dec 30, 2019
1747098
inference py blank lines at the end of the file removed
ivan-vasilev Dec 30, 2019
894ee24
inference.py imports fix
ivan-vasilev Dec 30, 2019
bdc8eb4
imports sorted with isort
ivan-vasilev Dec 30, 2019
bb37c8b
Merge pull request #1 from pandas-dev/master
ivan-vasilev Jan 1, 2020
b4de215
formatting and import fixes
ivan-vasilev Jan 1, 2020
d233945
Merge branch 'master' of https://github.com/ivan-vasilev/pandas
ivan-vasilev Jan 1, 2020
995326d
imports formatting fix
ivan-vasilev Jan 1, 2020
961ebb7
import reordering
ivan-vasilev Jan 1, 2020
4071dde
new line at the end of the file
ivan-vasilev Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def maybe_box(indexer, values, obj, key):
def maybe_box_datetimelike(value):
# turn a datetime like into a Timestamp/timedelta as needed

if isinstance(value, (np.datetime64, datetime)):
if isinstance(value, (np.datetime64, datetime)) and not isinstance(value, tslibs.Timestamp):
value = tslibs.Timestamp(value)
elif isinstance(value, (np.timedelta64, timedelta)):
value = tslibs.Timedelta(value)
Expand Down