Skip to content

Add epoch alternative to deprecation message #21060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018
Merged

Add epoch alternative to deprecation message #21060

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76822f4
Add epoch alternative to deprecation message
jorisvandenbossche May 15, 2018
29fa897
double quotes
jorisvandenbossche May 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/_libs/tslibs/timedeltas.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,9 @@ class Timedelta(_Timedelta):
msg = textwrap.dedent("""\
Floor division between integer array and Timedelta is
deprecated. Use 'array // timedelta.value' instead.
If you want to obtain epochs from an array of timestamps,
you can rather use
'array - pd.Timestamp("1970-01-01")) // pd.Timedelta('1s')'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe double quotes for the Timedelta('1s') just for clarity

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

""")
warnings.warn(msg, FutureWarning)
return other // self.value
Expand Down