Fixed KDE Plot to drop the missing values #14820

keshavramaswamy · 2016-12-08T01:38:48Z

closes KDE Plot does not drop missing values #14821
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

codecov-io · 2016-12-08T05:20:57Z

Current coverage is 85.30% (diff: 100%)

Merging #14820 into master will increase coverage by <.01%

@@             master     #14820   diff @@
==========================================
  Files           144        144          
  Lines         50957      51004    +47   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43469      43511    +42   
- Misses         7488       7493     +5   
  Partials          0          0

Powered by Codecov. Last update 86233e1...4273f8e

TomAugspurger · 2016-12-08T15:42:59Z

Can you add a test and a release note in whatsnew/0.19.2?

keshavramaswamy · 2016-12-08T15:43:55Z

Yes, I can do that

…nto kde-fix

jreback · 2016-12-10T15:33:44Z

can you rebase, problem with appeveyor which i just fixed

keshavramaswamy · 2016-12-10T15:34:29Z

Sure, I'll do that!

…

On Sat, Dec 10, 2016 at 10:33 AM Jeff Reback ***@***.***> wrote: can you rebase, problem with appeveyor which i just fixed — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14820 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGg1E01seEPTO65FIZGUbq1__9zCTGicks5rGsZfgaJpZM4LHV8J> .

TomAugspurger

Still need a test too. That can go in pandas/tests/plotting/test_series.py There's already a test in there with missing values test_kde_missing_vals, apparently not the right mix of missing values though.

Put a comment with a link to this issue when you make the new test. Thanks!

TomAugspurger · 2016-12-11T12:41:52Z

doc/source/whatsnew/v0.19.2.txt

@@ -78,4 +78,8 @@ Bug Fixes

 - Explicit check in ``to_stata`` and ``StataWriter`` for out-of-range values when writing doubles (:issue:`14618`)

+<<<<<<< HEAD


You can remove the git conflict markers.

yes, I noticed that - will add the required test too asap!

keshavramaswamy · 2016-12-12T18:50:27Z

@jreback - Is there a problem with the Travis CI?

jreback · 2016-12-12T19:08:22Z

you need to rebase on current master, I fixed this yesterday.

keshavramaswamy · 2016-12-14T06:33:45Z

Thanks @jreback - have rebased now.

TomAugspurger · 2016-12-14T12:50:23Z

pandas/tests/plotting/test_series.py

+        axes = _check_plot_works(s.plot.kde)
+        # check if the values have any missing values
+        # GH14821
+        self.assertTrue(any(~np.isnan(axes.lines[0]._xorig)),


Can you replace the ._xorig with .get_xdata()? Better to not use matplotlib's internal APIs.

TomAugspurger · 2016-12-14T12:53:17Z

One small change, then we should be good! We're aware of that travis failure on the 3.4 build.

TomAugspurger · 2016-12-15T15:40:48Z

@keshavramaswamy thanks!

BUG: Fixed KDE plot to ignore missing values closes pandas-dev#14821 * fixed kde plot to ignore the missing values * added comment to elaborate the changes made * added a release note in whatsnew/0.19.2 * added test to check for missing values and cleaned up whatsnew doc * added comment to refer the issue * modified to fit lint checks * replaced ._xorig with .get_xdata()

BUG: Fixed KDE plot to ignore missing values closes pandas-dev#14821 * fixed kde plot to ignore the missing values * added comment to elaborate the changes made * added a release note in whatsnew/0.19.2 * added test to check for missing values and cleaned up whatsnew doc * added comment to refer the issue * modified to fit lint checks * replaced ._xorig with .get_xdata() (cherry picked from commit 033d345)

Version 0.19.2 * tag 'v0.19.2': (78 commits) RLS: v0.19.2 DOC: update release notes for 0.19.2 TST: skip gbq upload test as flakey DOC: clean-up v0.19.2 whatsnew DOC: update Pandas Cheat Sheet (GH13202) DOC: Pandas Cheat Sheet TST: matplotlib 2.0 fix in log limits for barplot (GH14808) (pandas-dev#14957) flake8 fix import Remove test - from 0.20.0 PR slipped in PERF: fix getitem unique_check / initialization issue cache and remove boxing (pandas-dev#14931) CLN: Resubmit of GH14700. Fixes GH14554. Errors other than Indexing… Clean up construction of Series with dictionary and datetime index BUG: .fillna() for datetime64 with tz is passing thru floats BUG: Patch read_csv NA values behaviour ENH: merge_asof() has type specializations and can take multiple 'by' parameters (pandas-dev#13936) [Backport pandas-dev#14886] BUG: regression in DataFrame.combine_first with integer columns (GH14687) (pandas-dev#14886) Fixed KDE Plot to drop the missing values (pandas-dev#14820) ENH: merge_asof() has left_index/right_index and left_by/right_by (pandas-dev#14253) (pandas-dev#14531) TST: correct url for test file on s3 (xref pandas-dev#14587) ...

* releases: (78 commits) RLS: v0.19.2 DOC: update release notes for 0.19.2 TST: skip gbq upload test as flakey DOC: clean-up v0.19.2 whatsnew DOC: update Pandas Cheat Sheet (GH13202) DOC: Pandas Cheat Sheet TST: matplotlib 2.0 fix in log limits for barplot (GH14808) (pandas-dev#14957) flake8 fix import Remove test - from 0.20.0 PR slipped in PERF: fix getitem unique_check / initialization issue cache and remove boxing (pandas-dev#14931) CLN: Resubmit of GH14700. Fixes GH14554. Errors other than Indexing… Clean up construction of Series with dictionary and datetime index BUG: .fillna() for datetime64 with tz is passing thru floats BUG: Patch read_csv NA values behaviour ENH: merge_asof() has type specializations and can take multiple 'by' parameters (pandas-dev#13936) [Backport pandas-dev#14886] BUG: regression in DataFrame.combine_first with integer columns (GH14687) (pandas-dev#14886) Fixed KDE Plot to drop the missing values (pandas-dev#14820) ENH: merge_asof() has left_index/right_index and left_by/right_by (pandas-dev#14253) (pandas-dev#14531) TST: correct url for test file on s3 (xref pandas-dev#14587) ...

fixed kde plot to ignore the missing values

45a99ec

keshavramaswamy mentioned this pull request Dec 8, 2016

KDE Plot does not drop missing values #14821

Closed

keshavramaswamy changed the title ~~fixed kde plot to ignore the missing values~~ fixed kde plot to drop the missing values Dec 8, 2016

added comment to elaborate the changes made

101b0d4

keshavramaswamy changed the title ~~fixed kde plot to drop the missing values~~ Fixed KDE Plot to drop the missing values Dec 8, 2016

Keshav Ramaswamy added 2 commits December 8, 2016 12:05

added a release note in whatsnew/0.19.2

d2657e3

Merge branch 'kde-fix' of https://github.com/keshavramaswamy/pandas i…

24a6286

…nto kde-fix

jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Visualization plotting labels Dec 10, 2016

merged with master

bba56a0

TomAugspurger requested changes Dec 11, 2016

View reviewed changes

Keshav Ramaswamy added 3 commits December 11, 2016 11:51

added test to check for missing values and cleaned up whatsnew doc

59db2c6

added comment to refer the issue

e9f67e3

modified to fit lint checks

613cd72

Merge remote-tracking branch 'upstream/master' into kde-fix

c3237f0

TomAugspurger reviewed Dec 14, 2016

View reviewed changes

replaced ._xorig with .get_xdata()

4273f8e

TomAugspurger approved these changes Dec 14, 2016

View reviewed changes

TomAugspurger merged commit 033d345 into pandas-dev:master Dec 15, 2016

jorisvandenbossche added this to the 0.19.2 milestone Dec 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fixed KDE Plot to drop the missing values #14820

Fixed KDE Plot to drop the missing values #14820

Uh oh!

keshavramaswamy commented Dec 8, 2016 •

edited

Loading

Uh oh!

codecov-io commented Dec 8, 2016 •

edited

Loading

Uh oh!

TomAugspurger commented Dec 8, 2016 •

edited

Loading

Uh oh!

keshavramaswamy commented Dec 8, 2016

Uh oh!

jreback commented Dec 10, 2016

Uh oh!

keshavramaswamy commented Dec 10, 2016 via email

Uh oh!

TomAugspurger left a comment

Uh oh!

TomAugspurger Dec 11, 2016

Uh oh!

keshavramaswamy Dec 11, 2016

Uh oh!

keshavramaswamy commented Dec 12, 2016

Uh oh!

jreback commented Dec 12, 2016

Uh oh!

keshavramaswamy commented Dec 14, 2016

Uh oh!

TomAugspurger Dec 14, 2016

Uh oh!

TomAugspurger commented Dec 14, 2016

Uh oh!

TomAugspurger commented Dec 15, 2016

Uh oh!

Uh oh!

		@@ -78,4 +78,8 @@ Bug Fixes

		- Explicit check in ``to_stata`` and ``StataWriter`` for out-of-range values when writing doubles (:issue:`14618`)

		<<<<<<< HEAD

Uh oh!

Fixed KDE Plot to drop the missing values #14820

Fixed KDE Plot to drop the missing values #14820

Uh oh!

Conversation

keshavramaswamy commented Dec 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Dec 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 85.30% (diff: 100%)

Uh oh!

TomAugspurger commented Dec 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keshavramaswamy commented Dec 8, 2016

Uh oh!

jreback commented Dec 10, 2016

Uh oh!

keshavramaswamy commented Dec 10, 2016 via email

Uh oh!

TomAugspurger left a comment

Choose a reason for hiding this comment

Uh oh!

TomAugspurger Dec 11, 2016

Choose a reason for hiding this comment

Uh oh!

keshavramaswamy Dec 11, 2016

Choose a reason for hiding this comment

Uh oh!

keshavramaswamy commented Dec 12, 2016

Uh oh!

jreback commented Dec 12, 2016

Uh oh!

keshavramaswamy commented Dec 14, 2016

Uh oh!

TomAugspurger Dec 14, 2016

Choose a reason for hiding this comment

Uh oh!

TomAugspurger commented Dec 14, 2016

Uh oh!

TomAugspurger commented Dec 15, 2016

Uh oh!

Uh oh!

keshavramaswamy commented Dec 8, 2016 •

edited

Loading

codecov-io commented Dec 8, 2016 •

edited

Loading

TomAugspurger commented Dec 8, 2016 •

edited

Loading