-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
CleanIO CSVread_csv, to_csvread_csv, to_csvInternalsRelated to non-user accessible pandas implementationRelated to non-user accessible pandas implementationNeeds DiscussionRequires discussion from core team before further actionRequires discussion from core team before further action
Milestone
Description
pandas/io/parsers.py
is close to 4k LOC (3986 on 1.3 master). Would it be reasonable to split it into multiple files (located, say, in a pandas/io/parsers
directory)?
AFAICT the file contains 4 logical pieces:
read_...
methods (~700 LOC)ParserBase
and related module-level methods ( ~1100 LOC)CParser
and related module-level methods (~400LOC)PythonParser
, its derived classes and related module-level methods (~1800 LOC)
Once #38370 goes in these would be joined by
PyarrowParser
(~100 LOC right now)
IMO this kind of refactor would make the module somewhat easier to grok
Metadata
Metadata
Assignees
Labels
CleanIO CSVread_csv, to_csvread_csv, to_csvInternalsRelated to non-user accessible pandas implementationRelated to non-user accessible pandas implementationNeeds DiscussionRequires discussion from core team before further actionRequires discussion from core team before further action