-
-
Notifications
You must be signed in to change notification settings - Fork 145
feat(series): #1098 arithmetic truediv #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd34731
to
8e483f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the same issue here as in #1275 with the reverse operators. So my comments there apply here.
Also, I think it would be worthwhile to reorganize the declarations of the operators in series.pyi
. So you would have them in this order
__truediv__()
truediv()
div()
__rtruediv__()
rtruediv()
rdiv()
In #1275 you could do something similar for the addition operators. This will keep things better organized and together.
8e483f4
to
134e071
Compare
99b6ab6
to
e57e8b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, but can you reorganize the operations to keep things together, in this order:
__truediv__()
truediv()
__rtruediv__()
rtruediv()
Also, you don't need to do the overloads for div
and rdiv
. You can just do
div = truediv
rdiv = rtruediv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cmp0xff
assert_type()
to assert the type of any return value