set SQLALCHEMY_ENGINE_OPTIONS as default engine options #1399
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1396
use
SQLALCHEMY_ENGINE_OPTIONS
as default engine options especially if engine options is not specified inSQLALCHEMY_BINDS
.When engine options is not specified in
SQLALCHEMY_BINDS
, this engine will lack options with the bind. Which may cause some unexpected errors such as database disconnect error.For example, if someone use Flask-SQLalchemy like this, he will think
SQLALCHEMY_ENGINE_OPTIONS
will make effect inSQLALCHEMY_BINDS
. But that's not the case.This PR use
SQLALCHEMY_ENGINE_OPTIONS
as default engine options specifically when engine options is not specified inSQLALCHEMY_BINDS
. So the code above will be same as