chore: Rename message's StateHandlers to MessageStateHandlers
#1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lers` from `StateHandlers` avoiding the conflicting type problem introduced in pact-foundation#882. Fixes pact-foundation#1057
5 tasks
|
@mefellows is there a reason this one is stalled? It affects everyone using typescript and states ... which these days might be everyone. |
|
Thanks for the reminder, it just got lost in the pile - merging and releasing ASAP! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #882 the
StateHandlerstype was changed so that it was incompatible with the otherStateHandlerstype, resulting in conflicts when Typescript merged the two. This caused problems where it was impossible to correctly typeStateHandlers(see #1057).This PR is a breaking change that simply renames the message
StateHandlersinterface toMessageStateHandlers, and therefore fixes #1057.Probably the better fix would be to introduce a breaking change that makes both types the same again - but I didn't want to get in to untangling what is supposed to happen.
This must not be squash merged, otherwise you won't get the breaking change in the changelog.
npm run distworks locally (this will run tests, lint and build)