Fixes for cargo #629
Draft
Fixes for cargo #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prabhu
commented
Aug 23, 2025
prabhu
commented
- Corrected Typo: The non-standard attribute is_case_sensitve in name_definition has been corrected to the standard case_sensitive.
- Defined Requirements: Both the name_definition and version_definition are now correctly marked as "required", reflecting that they are mandatory components for a valid cargo purl.
- Improved Descriptions: The note fields for the name and version have been updated to be more specific. The name is clarified as the "package name," and the version note now specifies that it should follow the Semantic Versioning (SemVer) specification.
- Added Qualifiers Definition: A qualifiers_definition has been added to define the optional repository_url key, which is used to specify alternative registries for packages not hosted on crates.io.
Signed-off-by: Prabhu Subramanian <[email protected]>
matt-phylum
reviewed
Aug 25, 2025
| }, | ||
| "version_definition": { | ||
| "requirement": "required", |
There was a problem hiding this comment.
Suggested change
| "requirement": "required", |
Why would the version be required for Cargo specifically if it is not required for other, similar package managers?
| "native_name": "version", | ||
| "note": "The version is the package version." | ||
| "note": "The version is the package version. It should follow the Semantic Versioning (SemVer) specification." |
There was a problem hiding this comment.
What does it mean for PURL implementations that the version "should" be semver? Either it is semver or it is not semver. I don't know if it matters. This seems like unnecessary information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.