Re-enable viona packet data loaning #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the Chelsio driver now supporting bounded TX completion notifications, it should be safe to loan guest packet data in the mblk to avoid the extra alloc/copy.
|
FYI: PRing this now to get a build run, so it can be tested along with the updated helios kernel to ensure that oxidecomputer/omicron#7189 does not reoccur. |
|
@askfongjojo was kind enough to re-run the tests from the aforementioned omicron ticket on bits I installed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Chelsio driver now supporting bounded TX completion notifications, it should be safe to loan guest packet data in the mblk to avoid the extra alloc/copy.