Skip to content

Conversation

jmpesp
Copy link
Contributor

@jmpesp jmpesp commented Aug 9, 2025

Pick up the following PRs:

  • Snapshots existing already are ok!
  • Less verbose logging
  • Remove unused `Vec
  • Split "check reconciliation state" from "start reconciliation"
  • Improve ClientIoTask start logic
  • Use data-bearing enum variants pattern in negotiation
  • Make Downstairs stoppable
  • Don't log every region's metadata
  • Compute reconciliation from ClientMap instead of three clients
  • Make Offline -> Faulted transition happen without reconnecting
  • Remove WaitActive state during negotiation
  • Add explicit UpstairsState::Disabled
  • Print version on startup for pantry and agent
  • Update test mem to also show physical space used by regions.
  • Add AllStopped command and endpoint for downstairs status
  • Update tests to honor REGION_SETS env if provided.
  • Fix panic in set_active_request when client is in Stoppingstate
  • DTrace updates

Also updated dropshot.

@jmpesp jmpesp requested a review from leftwo August 9, 2025 00:57
@faithanalog
Copy link
Contributor

the clippy failure is new with rust 1.89.0. running cargo xtask clippy --strict, I don't get an error with 1.88.0, but I do with 1.89.0.

Pick up the following PRs:

- Snapshots existing already are ok!
- Less verbose logging
- Remove unused `Vec
- Split "check reconciliation state" from "start reconciliation"
- Improve `ClientIoTask` start logic
- Use data-bearing enum variants pattern in negotiation
- Make Downstairs stoppable
- Don't log every region's metadata
- Compute reconciliation from `ClientMap` instead of three clients
- Make Offline -> Faulted transition happen without reconnecting
- Remove `WaitActive` state during negotiation
- Add explicit `UpstairsState::Disabled`
- Print version on startup for pantry and agent
- Update test mem to also show physical space used by regions.
- Add AllStopped command and endpoint for downstairs status
- Update tests to honor REGION_SETS env if provided.
- Fix panic in `set_active_request` when client is in Stoppingstate
- DTrace updates

Also updated dropshot.
@faithanalog
Copy link
Contributor

rebased to get the fixes for clippy

@askfongjojo askfongjojo merged commit 23b06c2 into master Aug 10, 2025
11 checks passed
@askfongjojo askfongjojo deleted the update_crucible branch August 10, 2025 16:22
jmpesp added a commit to oxidecomputer/omicron that referenced this pull request Aug 11, 2025
Pick up the following propolis PRs:

- Bump crucible rev to latest (oxidecomputer/propolis#922)
- Added block_size for file backends in propolis_server (workers is optional) (oxidecomputer/propolis#917)

Pick up the following crucible PRs:

- Snapshots existing already are ok! (oxidecomputer/crucible#1759)
- Less verbose logging (oxidecomputer/crucible#1756)
- Remove unused `Vec<JoinHandle>` (oxidecomputer/crucible#1754)
- Split "check reconciliation state" from "start reconciliation" (oxidecomputer/crucible#1732)
- Improve `ClientIoTask` start logic (oxidecomputer/crucible#1731)
- Use data-bearing enum variants pattern in negotiation (oxidecomputer/crucible#1727)
- Make Downstairs stoppable (oxidecomputer/crucible#1730)
- Don't log every region's metadata (oxidecomputer/crucible#1729)
- Compute reconciliation from `ClientMap` instead of three clients (oxidecomputer/crucible#1726)
- Make Offline -> Faulted transition happen without reconnecting (oxidecomputer/crucible#1725)
- Remove `WaitActive` state during negotiation (oxidecomputer/crucible#1722)
- Add explicit `UpstairsState::Disabled` (oxidecomputer/crucible#1721)
- Print version on startup for pantry and agent (oxidecomputer/crucible#1723)
- Update test mem to also show physical space used by regions. (oxidecomputer/crucible#1724)
- Add AllStopped command and endpoint for downstairs status (oxidecomputer/crucible#1718)
- Update tests to honor REGION_SETS env if provided. (oxidecomputer/crucible#1720)
- Fix panic in `set_active_request` when client is in Stopping(Replacing) state (oxidecomputer/crucible#1717)
- DTrace updates (oxidecomputer/crucible#1715)
jmpesp added a commit to oxidecomputer/omicron that referenced this pull request Aug 11, 2025
Pick up the following propolis PRs:

- Bump crucible rev to latest (oxidecomputer/propolis#922)
- Added block_size for file backends in propolis_server (workers is optional) (oxidecomputer/propolis#917)

Pick up the following crucible PRs:

- Snapshots existing already are ok! (oxidecomputer/crucible#1759)
- Less verbose logging (oxidecomputer/crucible#1756)
- Remove unused `Vec<JoinHandle>` (oxidecomputer/crucible#1754)
- Split "check reconciliation state" from "start reconciliation" (oxidecomputer/crucible#1732)
- Improve `ClientIoTask` start logic (oxidecomputer/crucible#1731)
- Use data-bearing enum variants pattern in negotiation (oxidecomputer/crucible#1727)
- Make Downstairs stoppable (oxidecomputer/crucible#1730)
- Don't log every region's metadata (oxidecomputer/crucible#1729)
- Compute reconciliation from `ClientMap` instead of three clients (oxidecomputer/crucible#1726)
- Make Offline -> Faulted transition happen without reconnecting (oxidecomputer/crucible#1725)
- Remove `WaitActive` state during negotiation (oxidecomputer/crucible#1722)
- Add explicit `UpstairsState::Disabled` (oxidecomputer/crucible#1721)
- Print version on startup for pantry and agent (oxidecomputer/crucible#1723)
- Update test mem to also show physical space used by regions. (oxidecomputer/crucible#1724)
- Add AllStopped command and endpoint for downstairs status (oxidecomputer/crucible#1718)
- Update tests to honor REGION_SETS env if provided. (oxidecomputer/crucible#1720)
- Fix panic in `set_active_request` when client is in Stopping(Replacing) state (oxidecomputer/crucible#1717)
- DTrace updates (oxidecomputer/crucible#1715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants