fix(linter): catch-or-return handles arrow functions with implicit returns #17440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
catch-or-returnrule incorrectly flagged arrow functions with implicit returns as missing catch handlers, even though implicit returns are semantically equivalent to explicit returns.Changes
is_in_returned_contexthelper: Detects when anExpressionStatementis the body of an arrow function withexpression = true, indicating an implicit returnTechnical Details
Arrow functions with expression bodies (
() => expr) setexpression = trueon the AST node. The body still contains aFunctionBodywith anExpressionStatement, but the expression flag indicates it's implicitly returned. The fix walks the AST parent chain to detect this pattern.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.