Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Dec 28, 2025

Warning

this is a work in progress.

this is an experimental PR (for now, until I mark as ready for review) to add some slightly more realistic usage of the linter. namely that means:

  • linting multiple files at the same time
  • not running with fixes (as this is less common for things like CI or pre-push hooks)
  • maybe: running with only the most common plugins?

Copy link
Member Author

camchenry commented Dec 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #17407 will not alter performance

Comparing 12-27-ci_bench_add_real-world_linter_benchmarks (b5c04f5) with main (d2afdcf)

Summary

✅ 41 untouched
🆕 1 new
⏩ 4 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation calcom_repo N/A 2.2 s N/A

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry force-pushed the 12-27-ci_bench_add_real-world_linter_benchmarks branch 2 times, most recently from 5ec4394 to 2bfd074 Compare December 28, 2025 03:26
@camchenry camchenry force-pushed the 12-27-ci_bench_add_real-world_linter_benchmarks branch from 2bfd074 to b5c04f5 Compare December 28, 2025 04:05
@camchenry
Copy link
Member Author

@camc314 @overlookmotel any initial thoughts on this? this is a quick draft of a slightly more realistic linter setup. the codspeed time is still much slower than what it actually takes on my laptop (120ms to lint ~1200 files versus "2.2 seconds"), but this is at least closer to what actually happens during a real lint run.

@connorshea
Copy link
Contributor

Not particularly relevant to this PR, but we should probably have a benchmark that hits some configuration options for various rules, just to make sure we don't regress on that aspect of things in the future. Especially since we've unified config handling for many rules to go through DefaultRuleConfig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants