Skip to content

fix(formatter): JSXFragment missed a leading semicolon when semicolon is disabled #17386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dunqing wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −13
Open

fix(formatter): JSXFragment missed a leading semicolon when semicolon is disabled #17386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/oxc_formatter/src/write/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,7 @@ fn expression_statement_needs_semicolon<'a>(
| Expression::TSTypeAssertion(_)
| Expression::ArrowFunctionExpression(_)
| Expression::JSXElement(_)
| Expression::JSXFragment(_)
| Expression::TemplateLiteral(_) => true,
Expression::UnaryExpression(unary) => {
matches!(
Expand Down
14 changes: 1 addition & 13 deletions tasks/coverage/snapshots/formatter_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ commit: 2dfdbbab

formatter_typescript Summary:
AST Parsed : 9840/9840 (100.00%)
Positive Passed: 9781/9840 (99.40%)
Positive Passed: 9787/9840 (99.46%)
Mismatch: tasks/coverage/typescript/tests/cases/compiler/amdLikeInputDeclarationEmit.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/castExpressionParentheses.ts
Expand All @@ -19,14 +19,6 @@ Mismatch: tasks/coverage/typescript/tests/cases/compiler/dynamicNames.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/genericTypeAssertions3.ts
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/jsxFactoryAndJsxFragmentFactory.tsx
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/jsxFactoryAndJsxFragmentFactoryErrorNotIdentifier.tsx
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/jsxFactoryAndJsxFragmentFactoryNull.tsx
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/jsxFactoryButNoJsxFragmentFactory.tsx
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/letDeclarations-scopes2.ts
Expected `{` but found `Identifier`
Mismatch: tasks/coverage/typescript/tests/cases/compiler/parenthesizedExpressionInternalComments.ts
Expand Down Expand Up @@ -109,10 +101,6 @@ Mismatch: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxAttributeReso

Mismatch: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxExternalModuleEmit2.tsx

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxFragmentPreserveEmit.tsx
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxFragmentReactEmit.tsx
Unexpected token
Mismatch: tasks/coverage/typescript/tests/cases/conformance/jsx/tsxReactEmitWhitespace2.tsx

Mismatch: tasks/coverage/typescript/tests/cases/conformance/pedantic/noUncheckedIndexedAccessDestructuring.ts
Expand Down
Loading