fix(codegen): output trailing legal comments on same line #17357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17301
This PR adds support for outputting trailing legal comments on the same line as the statement they follow.
Before:
was output as:
After:
Changes
has_legal_content()method to Comment for checking legal content without position requirementbuild_comments()using span.start as keyprint_trailing_comments_after()to find and print trailing comments between statement end and next statement startprint_directives_and_statements()to print trailing comments after each statementpop()method to CodeBuffer for removing trailing newlinesTest plan
test_trailing_legal_comment