fix(linter/plugins): set up global scope correctly #17293
Merged
+8,359
−96,499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
This was referenced Dec 23, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR overhauls the global scope setup for the linter by removing the patch to @typescript-eslint/scope-manager and implementing a programmatic approach to manage global variables based on configuration. Instead of always using "esnext" globals, the system now creates globals according to env and globals from the config, and properly sets the writable property.
Key changes:
- Removed the patch file for
@typescript-eslint/scope-managerand updated dependency references to use the unpatched version - Implemented new
addGlobals()function in scope.ts that creates global variables from config and resolves references, replicating ESLint's behavior - Updated test case handling to build globals based on
ecmaVersionandsourceType, matching ESLint's preset behavior
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removes the patchedDependencies section that referenced the @typescript-eslint/scope-manager patch |
| pnpm-lock.yaml | Updates dependency snapshots to use the unpatched @typescript-eslint/scope-manager version |
| patches/@typescript-eslint__scope-manager.patch | Complete removal of the patch file that modified ImplicitLibVariable behavior |
| apps/oxlint/src-js/plugins/scope.ts | Major refactor adding addGlobals() and createGlobalVariable() functions to programmatically set up global scope with variables from env/globals config, and resolve references |
| apps/oxlint/conformance/src/rule_tester.ts | Adds logic to build globals from ESLint presets based on ecmaVersion/sourceType, with helper functions getGlobals(), getGlobalsForEcmaVersion(), and addGlobalsFromPreset() |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/12-22-refactor_linter_plugins_add_environments_definitions
branch
from
ba840df to
61868e3
Compare
overlookmotel
force-pushed
the
om/12-22-fix_linter_plugins_set_up_global_scope_correctly
branch
from
f7d734f to
5be63ec
Compare
graphite-app
bot
force-pushed
the
om/12-22-refactor_linter_plugins_add_environments_definitions
branch
from
61868e3 to
8dce152
Compare
graphite-app
bot
force-pushed
the
om/12-22-fix_linter_plugins_set_up_global_scope_correctly
branch
from
5be63ec to
a54c849
Compare
camc314
approved these changes
Dec 23, 2025
Contributor
Merge activity
|
graphite-app
bot
changed the base branch from
om/12-22-refactor_linter_plugins_add_environments_definitions
to
graphite-base/17293
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
Generate a file defining the vars that each environment (`env`) provides. This isn't used for anything yet, but it will be in next PR #17293. Vars for each environment are stored in this form: ```js { readonly: ["var1", "var2", "var3"], writable: ["var4", "var5"], } ``` instead of the more obvious: ```js { var1: false, var2: false, var3: false, var4: true, var5: true, } ``` ...because it's shorter code when there's lots of vars (which there usually are), and iterating through arrays I assume is faster than iterating through properties of objects (which are essentially hash maps when they're large).
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
Overhaul how variables in the global scope are set up. * Create globals according to `env` and `globals` from config - previously we always used a standard "esnext" set. * Remove the patch to `@typescript-eslint/scope-manager`. Instead do what ESLint does and patch up the global scope programmatically after TS-ESLint has produced the scope tree. * Set `writable` property for global variables according to config. This still isn't quite correct. There are many subtleties to this and I haven't got to the bottom of it all. But this PR fixes 500 conformance tests, so it's a large step in the right direction. I haven't added more tests in this PR, because I'm not actually sure what behavior is correct, and what still needs to be fixed. Once all the conformance tests related to globals (which is most of the remaining failing ones) are fixed, we'll have the full picture and can add more tests.
graphite-app
bot
force-pushed
the
om/12-22-fix_linter_plugins_set_up_global_scope_correctly
branch
from
a54c849 to
e05115b
Compare
Overhaul how variables in the global scope are set up. * Create globals according to `env` and `globals` from config - previously we always used a standard "esnext" set. * Remove the patch to `@typescript-eslint/scope-manager`. Instead do what ESLint does and patch up the global scope programmatically after TS-ESLint has produced the scope tree. * Set `writable` property for global variables according to config. This still isn't quite correct. There are many subtleties to this and I haven't got to the bottom of it all. But this PR fixes 500 conformance tests, so it's a large step in the right direction. I haven't added more tests in this PR, because I'm not actually sure what behavior is correct, and what still needs to be fixed. Once all the conformance tests related to globals (which is most of the remaining failing ones) are fixed, we'll have the full picture and can add more tests.
graphite-app
bot
force-pushed
the
om/12-22-fix_linter_plugins_set_up_global_scope_correctly
branch
from
e05115b to
7eaa660
Compare
graphite-app
bot
deleted the
om/12-22-fix_linter_plugins_set_up_global_scope_correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul how variables in the global scope are set up.
envandglobalsfrom config - previously we always used a standard "esnext" set.@typescript-eslint/scope-manager. Instead do what ESLint does and patch up the global scope programmatically after TS-ESLint has produced the scope tree.writableproperty for global variables according to config.This still isn't quite correct. There are many subtleties to this and I haven't got to the bottom of it all. But this PR fixes 500 conformance tests, so it's a large step in the right direction.
I haven't added more tests in this PR, because I'm not actually sure what behavior is correct, and what still needs to be fixed. Once all the conformance tests related to globals (which is most of the remaining failing ones) are fixed, we'll have the full picture and can add more tests.