fix(linter): merge ignorePatterns when extending configurations #17286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the merge logic in the Oxlintrc struct to combine ignore patterns from two configurations, ensuring that the patterns from the 'other' configuration take precedence. Added unit tests to verify the correct merging behavior of ignore patterns.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where ignorePatterns from extended configurations were not being merged properly. Previously, only the current config's patterns were used, completely ignoring patterns from extended configs.
Key changes:
- Updated the
mergemethod to combineignore_patternsfrom both the extended config and the current config - Added comprehensive test coverage to verify the merge behavior in various scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Michael Ireland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written by Cursor!
The
extendsfield in the configuration files does not currently extend ignorePatterns.Reproducible here: https://github.com/MIreland/monorepo-filter-examples/blob/main/app/package-a/package.json#L10
Fixes a bug where `ignorePatterns` from extended configurations were not being merged.
Problem
The `merge` method in `oxlintrc.rs` was only using `self.ignore_patterns` and completely ignoring `other.ignore_patterns` from extended configs.
Solution
Updated the merge logic to combine ignore patterns from both the extended config (`other`) and the current config (`self`), following the same pattern used for `overrides` and `categories`.
Changes
Testing