feat(linter/eslint-plugin-vitest): Implemented vitest/warn-todo rule #17228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #17228 will not alter performanceComparing Summary
Footnotes
|
connorshea
requested changes
Dec 21, 2025
Contributor
connorshea
left a comment
connorshea
left a comment
There was a problem hiding this comment.
Documentation suggestions :)
connorshea
changed the title
Afsoon
force-pushed
the
vitest-warn-todo
branch
from
ed208c3 to
f7becef
Compare
camc314
reviewed
Dec 22, 2025
Comment on lines
55
to
62
| fn run_once(&self, ctx: &LintContext) { | ||
| let mut possibles_jest_nodes = collect_possible_jest_call_node(ctx); | ||
| possibles_jest_nodes.sort_unstable_by_key(|n| n.node.id()); | ||
|
|
||
| for possible_jest_node in &possibles_jest_nodes { | ||
| WarnTodo::run(possible_jest_node, ctx); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
we can use run_on_jest_node rather than manually collecting the calls here
Contributor
Author
There was a problem hiding this comment.
Updated to use run_on_jest_node
Afsoon
force-pushed
the
vitest-warn-todo
branch
2 times, most recently
from
99936dd to
922b59d
Compare
Co-authored-by: Connor Shea <[email protected]> Signed-off-by: Said Atrahouch <[email protected]>
…nd update snpashots
Afsoon
force-pushed
the
vitest-warn-todo
branch
from
922b59d to
3a908e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4656
Implement
warn-todovitest rule