-
-
Notifications
You must be signed in to change notification settings - Fork 763
feat(linter/eslint-plugin-vitest): Implement valid-title eslint rule #17224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #17224 will not alter performanceComparing Summary
Footnotes
|
connorshea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started a review and then realized that... technically valid-title is already implemented for vitest partially via the jest/valid-title rule? It just wasn't done properly: bd74603
Do we need to do anything specific for that?
| #[serde(default)] | ||
| #[serde(rename = "vitestImports")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #[serde(default)] | |
| #[serde(rename = "vitestImports")] | |
| #[serde(rename = "vitestImports", default)] |
|
@connorshea Looks that not, we have to extend the current Thanks! |
af86eb8 to
a7287be
Compare
|
Doing from zero |
5f8359f to
6a318d7
Compare
|
@camc314 I have recovered the changes I made to handle the test with |
6a318d7 to
b1ff2de
Compare
Related to #4656
Set
valid-titleas a compatible vitest ruleoxc-project/oxlint-migrate#301