perf(linter/approx-constant): break after first match to avoid extra iterations

[camc314]

No description provided.

[camc314]

• perf(linter/approx-constant): break after first match to avoid extra iterations #16848 👈 (View in Graphite)
• feat(linter/approx-constant): implement fixer #16847
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[charliecreates]

No issues found with this change. The added break; is a clear, safe micro-optimization that also prevents duplicate diagnostics once a match has been handled.

Additional notes (1)

• Maintainability | crates/oxc_linter/src/rules/oxc/approx_constant.rs:67-71
  Adding break after the first diagnostic changes behavior if the loop could legitimately find multiple approximate constants that should each be reported for the same number_literal/node (or if the loop is iterating over multiple candidate constants to choose a best match). If multiple reports were previously possible/desired, this will silently reduce diagnostics to one.

Given the PR title, that may be intentional, but the code currently doesn’t make it obvious that the first match is the correct/only match (e.g., if candidate ordering changes, you might report a less-ideal constant). Consider ensuring determinism/quality by explicitly selecting the best match (or documenting that candidates are mutually exclusive / ordered by preference).

Summary of changes

What changed

• In ApproxConstant rule, added a break; immediately after emitting a diagnostic via ctx.diagnostic_with_suggestion(...).
• This stops iterating after the first match is found, reducing unnecessary loop iterations and avoiding multiple diagnostics for the same visit.

Key code change

• Added break; after the diagnostic call within the loop that searches for an approximate constant match.

[graphite-app]

Merge activity

• Dec 14, 5:15 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 14, 5:21 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
• Dec 14, 6:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 14, 6:15 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 14, 6:21 PM UTC: Merged by the Graphite merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #16848 will not alter performance

_{Comparing c/12-14-perf_linter_approx-constant_break_after_first_match_to_avoid_extra_iterations (e86da34) with main (2f77a1a)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR adds a performance optimization to the approx_constant linter rule by breaking out of the loop after finding the first matching constant, avoiding unnecessary iterations through the remaining constants.

• Adds a break statement after the first constant match is found and reported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.