test(linter/plugins): refactor tokens tests #16804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-test
This was referenced Dec 13, 2025
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
setup()currently resets state despite comments implying it’s only needed to change the source text, leading to redundant resets and a confusing helper contract.- The
beforeEachcomment refers tosetSourceText, but the helper is namedsetup, creating inconsistency and reducing clarity.
Summary of changes
Summary
Refactors apps/oxlint/test/tokens.test.ts to centralize per-test initialization:
- Introduces a
setup(text: string)helper that callsresetSourceAndAst()and assignssourceText. - Updates the
beforeEachhook to callsetup(SOURCE_TEXT)instead of duplicating reset/assignment logic. - Replaces many direct
sourceText = ...assignments (and several redundantresetSourceAndAst()calls) withsetup(...)in individual test cases. - Keeps behavior the same while reducing repeated boilerplate across token-store tests.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the token plugin unit tests to improve consistency and maintainability by introducing a setup() function that encapsulates test state initialization. The refactor eliminates code duplication and removes redundant resetSourceAndAst() calls that were already being handled by the beforeEach hook.
Key Changes:
- Introduced a
setup()helper function that combinesresetSourceAndAst()andsourceTextassignment - Replaced all direct
sourceText = "..."assignments withsetup("...")calls throughout the test suite - Removed redundant
resetSourceAndAst()calls since thebeforeEachhook now handles reset viasetup()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
overlookmotel
force-pushed
the
12-13-test_linter_plugins_refactor_tokens_tests
branch
from
c457c5c to
bfbf14d
Compare
overlookmotel
force-pushed
the
12-13-test_linter_plugins_tests_use_oxc_parser
branch
from
8d2b90f to
005982b
Compare
Member
Author
Merge activity
|
Pure refactor of tests. In tokens unit tests, use a `setup` function to set source text for each test, rather than writing to local `sourceText` var. Remove a bunch of unnecessary `resetSourceAndAst()` calls. `beforeEach` hook does this already before each test.
graphite-app
bot
force-pushed
the
12-13-test_linter_plugins_tests_use_oxc_parser
branch
from
005982b to
5619f9e
Compare
graphite-app
bot
force-pushed
the
12-13-test_linter_plugins_refactor_tokens_tests
branch
from
bfbf14d to
d734b86
Compare
Base automatically changed from
12-13-test_linter_plugins_tests_use_oxc_parser
to
main
December 13, 2025 18:57
graphite-app
bot
deleted the
12-13-test_linter_plugins_refactor_tokens_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor of tests.
In tokens unit tests, use a
setupfunction to set source text for each test, rather than writing to localsourceTextvar.Remove a bunch of unnecessary
resetSourceAndAst()calls.beforeEachhook does this already before each test.