fix(oxfmt): Report exitCode correctly

[leaysgur]

Previously,

• oxfmt(napi) not-exists.js returns exitCode: 1
• oxfmt(rust) not-exists.js returns exitCode: 2 = Expected

To fix this, I updated napi callback return value from bool.

Additionally, I realized that by returning the processing Mode simultaneously, Rust can handle the CLI arguments in better way. Like --init --help, which now shows help.

And finally changed napi binding name from format() to runCli() for the future Node API.

[leaysgur]

• fix(oxfmt): Report exitCode correctly #16770 👈 (View in Graphite)
• refactor(oxfmt): Rewrite --init mode in JS #16769
• fix(oxfmt): Make Rust CLI as just formatting CLI #16768
• fix(oxfmt): Remove jsonc parser override for (j|t)sconfig(.*)?.json #16762
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[charliecreates]

The change generally aligns exit code reporting between Rust and JS, but the new tuple-based contract has a few correctness and robustness gaps. cli.ts can accidentally assign process.exitCode = undefined if exitCode is missing, and the N-API arg-parse error path currently collapses non-zero parser exit codes into 1, which may undermine “report exitCode correctly”. The .d.ts type is looser than runtime (null), and returning mode as free-form String increases the chance of drift/typos across the FFI boundary.

Additional notes (1)

• Maintainability | apps/oxfmt/src/main_napi.rs:28-28
run_cli returns (String, Option<u8>) and constructs mode strings via "cli".to_string() etc. This is error-prone (typos become runtime bugs) and pushes a looser type across the FFI boundary. Since the JS side branches on a closed set of modes, it’s better to encode that as a Rust enum exported to N-API (or at least a &'static str / Cow<'static, str> that can only be one of the known values).

Even if you keep a string, consider centralizing the literals to avoid drift between Rust docs, Rust return values, and TS declaration.

Summary of changes

What changed

• N-API surface changed from boolean to structured result

  • Replaced exported binding format with runCli / run_cli.
  • Updated TypeScript declarations to return a tuple [mode, exitCode] where mode is one of "cli" | "lsp" | "init" and exitCode is set only for CLI.

• JS CLI now delegates mode parsing to Rust (apps/oxfmt/src-js/cli.ts)

  • Calls runCli(args, ...) and switches on mode.
  • Sets process.exitCode based on Rust-provided exitCode for "cli" mode.
  • Reintroduces --init handling, but only after Rust indicates "init" mode.

• Rust exit code handling is centralized (apps/oxfmt/src/cli/result.rs)

  • Added CliRunResult::exit_code() returning u8.
  • Termination::report() now uses self.exit_code().

• N-API entry point now returns mode + exit code (apps/oxfmt/src/main_napi.rs)

  • format(...) -> bool replaced with run_cli(...) -> (String, Option<u8>).
  • On arg-parse failures, returns ("cli", Some(0|1)) after printing message.
  • Mode::Init now returns ("init", None) instead of unreachable!.

• Tests updated

  • Snapshots updated to expect exit code 2 for “no files found/expected at least one target file” scenarios.

[Boshen]

Merge activity

• Dec 12, 5:41 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 12, 5:53 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 12, 5:56 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Dec 12, 6:01 AM UTC: Merged by the Graphite merge queue.

[leaysgur]

Too fast approve! I was fixing CI...😗