-
-
Notifications
You must be signed in to change notification settings - Fork 764
feat(oxfmt): Support quoteProps: consistent in Oxfmtrc
#16721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oxfmt): Support quoteProps: consistent in Oxfmtrc
#16721
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
quoteProps: consistent in Oxfmtrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables support for the quoteProps: "consistent" formatter option in oxfmt. The underlying implementation for consistent quote properties already exists in the formatter; this PR exposes it through the configuration layer by adding the "consistent" option to schemas and configuration mappings.
Key changes:
- Added "consistent" to the QuotePropsConfig enum and JSON schemas
- Updated configuration mapping to handle QuotePropsConfig::Consistent
- Removed the "NOTE: 'consistent' is not supported" comment
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/acorn-test262 | Removed subproject reference (unrelated to feature) |
| npm/oxfmt/configuration_schema.json | Added "consistent" option to QuotePropsConfig enum in schema |
| napi/playground/src/options.rs | Updated documentation to include "consistent" option |
| crates/oxc_formatter/tests/snapshots/schema_json.snap | Updated test snapshot to reflect schema changes |
| crates/oxc_formatter/src/service/oxfmtrc.rs | Added QuotePropsConfig::Consistent enum variant and mapping logic; removed unsupported comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1350f5e to
d800fb2
Compare
CodSpeed Performance ReportMerging #16721 will not alter performanceComparing Summary
Footnotes
|
Merge activity
|
d800fb2 to
afd6c44
Compare

Follow up #16677, fixes #16247.