feat(linter/plugins): RuleTester support languageOptions.sourceType
#16660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
This was referenced Dec 9, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for languageOptions.sourceType in the RuleTester, enabling test cases and configurations to specify how source files should be parsed (as script, module, or unambiguous). The implementation correctly handles differences between standard and ESLint-compatibility modes, where "unambiguous" is supported in standard mode and "commonjs" (treated as "script") is supported in ESLint-compat mode. This enhancement fixes approximately 300 conformance tests by providing more accurate parsing context.
Key Changes
- Added
ParseOptionssupport to theparse()function call in the lint workflow - Implemented proper merging of
languageOptionsfrom configs and test cases with precedence handling - Added sourceType validation and conversion logic that differentiates between standard and ESLint-compat modes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
…e` (#16660) `RuleTester` use `languageOptions.sourceType` in config / test case definition to determine whether to parse a file as script or module. * In standard mode, `sourceType: "unambiguous"` is also supported. * In ESLint-compat mode, `sourceType: "commonjs"` is also supported (treated the same as `"script"`). This fixes ~300 conformance tests.
graphite-app
bot
force-pushed
the
12-09-test_linter_plugins_allow_filtering_by_rule_or_test_case_in_conformance_tester
branch
from
c1324c6 to
973a1ba
Compare
graphite-app
bot
force-pushed
the
12-09-feat_linter_plugins_ruletester_support_languageoptions.sourcetype_
branch
from
809ac17 to
4cf1353
Compare
Base automatically changed from
12-09-test_linter_plugins_allow_filtering_by_rule_or_test_case_in_conformance_tester
to
main
December 9, 2025 18:51
graphite-app
bot
deleted the
12-09-feat_linter_plugins_ruletester_support_languageoptions.sourcetype_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
) Follow-on after #16660. Add tests for `languageOptions.sourceType` in `RuleTester`.
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…e` (#16660) `RuleTester` use `languageOptions.sourceType` in config / test case definition to determine whether to parse a file as script or module. * In standard mode, `sourceType: "unambiguous"` is also supported. * In ESLint-compat mode, `sourceType: "commonjs"` is also supported (treated the same as `"script"`). This fixes ~300 conformance tests.
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
) Follow-on after #16660. Add tests for `languageOptions.sourceType` in `RuleTester`.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…e` (oxc-project#16660) `RuleTester` use `languageOptions.sourceType` in config / test case definition to determine whether to parse a file as script or module. * In standard mode, `sourceType: "unambiguous"` is also supported. * In ESLint-compat mode, `sourceType: "commonjs"` is also supported (treated the same as `"script"`). This fixes ~300 conformance tests.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…-project#16670) Follow-on after oxc-project#16660. Add tests for `languageOptions.sourceType` in `RuleTester`.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ester` (oxc-project#16671) Follow-on after oxc-project#16660. Add 1 more test that I missed in oxc-project#16670.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuleTesteruselanguageOptions.sourceTypein config / test case definition to determine whether to parse a file as script or module.sourceType: "unambiguous"is also supported.sourceType: "commonjs"is also supported (treated the same as"script").This fixes ~300 conformance tests.