Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 9, 2025

Add to types for Config and TestCase in RuleTester. Similar to #16641, these options are currently ignored, but it prepares the way for other changes to RuleTester in future PRs.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request labels Dec 9, 2025
Copy link
Member Author

overlookmotel commented Dec 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2025 10:00
Copilot AI review requested due to automatic review settings December 9, 2025 10:00
@overlookmotel overlookmotel self-assigned this Dec 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive TypeScript type definitions for languageOptions to the RuleTester configuration system, aligning with ESLint's flat config API. While these options are currently ignored (similar to PR #16641), this change lays the groundwork for future RuleTester enhancements by establishing proper type contracts.

  • Adds LanguageOptions interface with properties for ecmaVersion, sourceType, globals, parser, and parserOptions
  • Introduces supporting types (SourceType, ParserOptions, EcmaFeatures, Language) with appropriate documentation
  • Exports all new types through the RuleTester namespace for external use

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel force-pushed the 12-08-feat_linter_plugins_add_languageoptions_types_to_ruletester_config_types branch from d15093b to e19cfb5 Compare December 9, 2025 11:21
@overlookmotel overlookmotel force-pushed the 12-08-feat_linter_plugins_ruletester_parser_support_options branch 2 times, most recently from d5bf26a to fbdd54f Compare December 9, 2025 11:58
@overlookmotel overlookmotel force-pushed the 12-08-feat_linter_plugins_add_languageoptions_types_to_ruletester_config_types branch from e19cfb5 to 94c5679 Compare December 9, 2025 11:58
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copy link
Member Author

overlookmotel commented Dec 9, 2025

Merge activity

…fig types (#16642)

Add to types for `Config` and `TestCase` in `RuleTester`. Similar to #16641, these options are currently ignored, but it prepares the way for other changes to `RuleTester` in future PRs.
@graphite-app graphite-app bot force-pushed the 12-08-feat_linter_plugins_ruletester_parser_support_options branch from fbdd54f to 554250e Compare December 9, 2025 12:48
@graphite-app graphite-app bot force-pushed the 12-08-feat_linter_plugins_add_languageoptions_types_to_ruletester_config_types branch from 94c5679 to 8c8b6d9 Compare December 9, 2025 12:48
Base automatically changed from 12-08-feat_linter_plugins_ruletester_parser_support_options to main December 9, 2025 12:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@graphite-app graphite-app bot merged commit 8c8b6d9 into main Dec 9, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-08-feat_linter_plugins_add_languageoptions_types_to_ruletester_config_types branch December 9, 2025 12:54
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
…fig types (#16642)

Add to types for `Config` and `TestCase` in `RuleTester`. Similar to #16641, these options are currently ignored, but it prepares the way for other changes to `RuleTester` in future PRs.
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…fig types (oxc-project#16642)

Add to types for `Config` and `TestCase` in `RuleTester`. Similar to oxc-project#16641, these options are currently ignored, but it prepares the way for other changes to `RuleTester` in future PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants