-
-
Notifications
You must be signed in to change notification settings - Fork 764
feat(linter): promote no_map_spread rule from nursery to perf #16604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): promote no_map_spread rule from nursery to perf #16604
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR promotes the no_map_spread linter rule from the nursery category to the performance category after 13 months of testing and stabilization. This rule identifies inefficient use of object and array spreads in map and flatMap calls.
- Updates the rule category from
nurserytoperfin thedeclare_oxc_lint!macro - Removes the TODO comment about battle-testing the rule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #16604 will not alter performanceComparing Summary
Footnotes
|
This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance
eac240c to
7c7219e
Compare
This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance
…oject#16604) This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance

This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance