feat(linter): add dangerous suggestion for jsx-a11y/tabindex-no-positive
#12963
+38
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #12963 will not alter performanceComparing Summary
Footnotes
|
camc314
approved these changes
Aug 12, 2025
Merge activity
|
…tive` (#12963) There should be 3 different fixes, but I moved with the "safest" one: ### Change tabindex to 0 Still be focusable with the keyboard ### Changing tabindex to -1 Could work when the focus is only needed with the JS API `element.focus()` ### Removing tabindex This could break applications which have custom aria roles and need the tabindex to work correctly.
graphite-app
bot
force-pushed
the
08-10-feat_linter_add_dangerous_suggestion_for_jsx-a11y_tabindex-no-positive_
branch
from
fbc101c to
4ce252c
Compare
graphite-app
bot
deleted the
08-10-feat_linter_add_dangerous_suggestion_for_jsx-a11y_tabindex-no-positive_
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…tive` (oxc-project#12963) There should be 3 different fixes, but I moved with the "safest" one: ### Change tabindex to 0 Still be focusable with the keyboard ### Changing tabindex to -1 Could work when the focus is only needed with the JS API `element.focus()` ### Removing tabindex This could break applications which have custom aria roles and need the tabindex to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be 3 different fixes, but I moved with the "safest" one:
Change tabindex to 0
Still be focusable with the keyboard
Changing tabindex to -1
Could work when the focus is only needed with the JS API
element.focus()Removing tabindex
This could break applications which have custom aria roles and need the tabindex to work correctly.