Skip to content

fix(linter): improve jest/no-restricted-matchers #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2025
Merged

fix(linter): improve jest/no-restricted-matchers #11292

merged 2 commits into from
May 25, 2025

Conversation

ulrichstark
Copy link
Contributor

@ulrichstark ulrichstark commented May 25, 2025 •
edited
Loading

  • re-word diagnostic messages ("Disallow specific matchers & modifiers" => "Use of {chain_call} is disallowed")
  • add section describing how configuring this rule works
  • minor other code refactorings to improve readability

@ulrichstark ulrichstark requested a review from camc314 as a code owner May 25, 2025 19:23
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels May 25, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 25, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11292 will degrade performances by 12.77%

Comparing ulrichstark:improve-jest-no-restricted-matchers (fd60449) with main (3a49220)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ mangler[cal.com.tsx] 3 ms 3.5 ms -12.77%

@camc314 camc314 merged commit 14f790f into oxc-project:main May 25, 2025
22 checks passed
@ulrichstark ulrichstark deleted the improve-jest-no-restricted-matchers branch May 25, 2025 19:40
@oxc-bot oxc-bot mentioned this pull request May 30, 2025
Merged
camc314 added a commit that referenced this pull request May 30, 2025
@oxc-bot @camc314
release(oxlint): v0.17.0 (#11402)
9fda4f5 
## [0.17.0] - 2025-05-30

- ead5309 linter: [**BREAKING**] Remove react from default plugin set
(#11382) (camc314)

### Features

- 2d25bd8 linter: Remove `unicorn/no-for-loop` over
`typescript/prefer-for-of` (#11354) (camc314)
- bbb7eb1 linter: Add auto-fix to react/forward-ref-uses-ref (#11342)
(yefan)
- 590c27b linter: Add auto-fix to unicorn/no-await-expression-member
(#11306) (yefan)
- 7824f01 linter: Implement suggestion for `jsx/no-useless-fragment`
(#10800) (Cam McHenry)
- 2083d33 linter/language_server: Add second editor suggestion for
`react/forward-ref-uses-ref` (#11375) (Sysix)

### Bug Fixes

- f6424dd linter: Reflect react plugin is disabled by default in cli
(#11397) (camc314)
- 25ecbfe linter: Remove use of `FrameworkFlags::React` to decide
whether rules should run (#11383) (camc314)
- 0d240e4 linter: False positive in react/exhaustive-deps with default
formal parameter (#11395) (camc314)
- c91697e linter: Fix panic in multi byte char in `TryFrom` aria
(#11350) (camc314)
- 9798ef1 linter: Stack overflow in no-async-endpoint-handlers (#11317)
(camc314)
- 348ad97 linter: Skip no-unused-vars on astro files (#11303) (camc314)
- 183d7f0 linter: Make `jest/no-large-snapshots` error easier to
comprehend (#11294) (Ulrich Stark)
- 4e606a5 linter: Improve `jest/no-large-snapshots` (#11291) (Ulrich
Stark)
- 14f790f linter: Improve `jest/no-restricted-matchers` (#11292) (Ulrich
Stark)
- a2c82be linter/block-scoped-var: Better diagnostic messages (#11290)
(DonIsaac)
- 19772e5 linter/no-unused-vars: Panic when variable is redeclared as
function in same scope (#11280) (Dunqing)
- 7af5bb1 oxc_language_server: Include save option for text document
sync capability (#11297) (Nicholas Rayburn)

### Performance

- 0ed6c1a language_server: Use `Arc<RwLock>` instead of `Mutex` for
workspace workers (#11328) (Sysix)
- a0ee946 linter: Reduce code size in `globals` (#11333) (shulaoda)
- c90c5e9 linter/no-unused-vars: Simplify checking self call usage
(#11281) (Dunqing)

### Documentation

- eae51ca linter: Clarify jsdoc/check-tag-names configuration (#11394)
(Rägnar O'ock)
- cd354d4 oxlint: Remove incorrect doc comment (#11326) (camc314)

### Refactor

- 42738f0 linter: Shorten code of match arms (#11389) (Ulrich Stark)
- 8a34447 linter: Improve `unicorn/text-encoding-identifier-case`
(#11386) (shulaoda)
- eaa605e linter: Avoid some `Arc::clone` in linter runtime (#11388)
(Boshen)
- 1cd8b9c linter: Fixes in `react/forward-ref-uses-ref` are suggestions
(#11376) (Sysix)
- 50ef691 linter: Add `diagnostics_with_multiple_fixes` to `LintContext`
(#11357) (Sysix)
- 606bb34 linter: Accept `PossibleFixes` instead of `Fix` for `Messages`
(#11295) (Sysix)
- 042a3f3 linter: Use `PossibleFixes` instead of `Option<Fix>` (#11284)
(Sysix)
- ffcfb46 linter: Improve `unicorn/throw-new-error` (#11364) (shulaoda)
- 8fb55c3 linter: Cleanup docs and simplify code of
`eslint/no-fallthrough` (#11331) (Ulrich Stark)
- e2f0f0a linter: Improve docs and simplify code of
`eslint/no-duplicate-imports` (#11320) (Ulrich Stark)
- b53b053 linter: Simplify accessing span of NameSpan (#11305) (Ulrich
Stark)
- 4bc2650 linter: Improve `eslint/no-void` (#11285) (shulaoda)

### Styling

- 49b664c linter: Remove needless newline in `declare_oxc_lint` (#11400)
(camc314)

### Testing

- c4f64aa linter: Explicitly disable correctness for clarity (#11327)
(camc314)
- a404b2c linter: `eslint/no-duplicate-imports` shouldn't report the
same span (#11324) (Ulrich Stark)

Co-authored-by: camc314 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulrichstark @camc314