☂️ eslint-plugin-unicorn

[Boshen]

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is the tracking issue for eslint-plugin-unicorn.

There are 141(+ 3 deprecated) rules.

• 11/132 recommended rules are remaining as TODO
  • 30 of which have pending fixes
• 8/9 not recommended rules are remaining as TODO

To get started, run the following command:

just new-unicorn-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✅: 119, 🚫: 2, ⏳: 30 / total: 132

Status	Name
✅	unicorn/catch-error-name
✅	unicorn/consistent-assert
✅	unicorn/consistent-date-clone
✅	unicorn/consistent-empty-array-spread
✅	unicorn/consistent-existence-index-check
✅⏳	unicorn/consistent-function-scoping
✅	unicorn/empty-brace-spaces
✅	unicorn/error-message
✅	unicorn/escape-case
	unicorn/expiring-todo-comments
✅	unicorn/explicit-length-check
✅	unicorn/filename-case
	unicorn/import-style
✅	unicorn/new-for-builtins
✅	unicorn/no-abusive-eslint-disable
✅	unicorn/no-accessor-recursion
✅	unicorn/no-anonymous-default-export
✅⏳	unicorn/no-array-callback-reference
✅⏳	unicorn/no-array-for-each
✅⏳	unicorn/no-array-method-this-argument
✅	unicorn/no-array-reduce
✅	unicorn/no-array-reverse
✅	unicorn/no-array-sort
✅	unicorn/no-await-expression-member
✅	unicorn/no-await-in-promise-methods
✅	unicorn/no-console-spaces
✅	unicorn/no-document-cookie
✅	unicorn/no-empty-file
🚫	unicorn/no-for-loop
✅	unicorn/no-hex-escape
✅⏳	unicorn/no-immediate-mutation
✅⏳	unicorn/no-instanceof-builtins
✅	unicorn/no-invalid-fetch-options
✅	unicorn/no-invalid-remove-event-listener
✅	unicorn/no-lonely-if
✅	unicorn/no-magic-array-flat-depth
🚫	unicorn/no-named-default
✅⏳	unicorn/no-negated-condition
✅	unicorn/no-negation-in-equality-check
✅	unicorn/no-nested-ternary
✅⏳	unicorn/no-new-array
✅⏳	unicorn/no-new-buffer
✅	unicorn/no-null
✅	unicorn/no-object-as-default-parameter
✅⏳	unicorn/no-process-exit
✅	unicorn/no-single-promise-in-promise-methods
✅	unicorn/no-static-only-class
✅	unicorn/no-thenable
✅	unicorn/no-this-assignment
✅⏳	unicorn/no-typeof-undefined
✅	unicorn/no-unnecessary-array-flat-depth
✅	unicorn/no-unnecessary-array-splice-count
✅	unicorn/no-unnecessary-await
	unicorn/no-unnecessary-polyfills
✅	unicorn/no-unnecessary-slice-end
✅	unicorn/no-unreadable-array-destructuring
✅	unicorn/no-unreadable-iife
✅⏳	unicorn/no-useless-collection-argument
✅⏳	unicorn/no-useless-error-capture-stack-trace
✅	unicorn/no-useless-fallback-in-spread
✅⏳	unicorn/no-useless-length-check
✅	unicorn/no-useless-promise-resolve-reject
✅	unicorn/no-useless-spread
✅⏳	unicorn/no-useless-switch-case
✅	unicorn/no-useless-undefined
✅	unicorn/no-zero-fractions
✅	unicorn/number-literal-case
✅	unicorn/numeric-separators-style
✅⏳	unicorn/prefer-add-event-listener
✅⏳	unicorn/prefer-array-find
✅	unicorn/prefer-array-flat
✅	unicorn/prefer-array-flat-map
✅⏳	unicorn/prefer-array-index-of
✅	unicorn/prefer-array-some
✅	unicorn/prefer-at
✅	unicorn/prefer-bigint-literals
✅⏳	unicorn/prefer-blob-reading-methods
✅	unicorn/prefer-class-fields
✅	unicorn/prefer-classlist-toggle
✅	unicorn/prefer-code-point
✅	unicorn/prefer-date-now
✅⏳	unicorn/prefer-default-parameters
✅	unicorn/prefer-dom-node-append
✅⏳	unicorn/prefer-dom-node-dataset
✅	unicorn/prefer-dom-node-remove
✅	unicorn/prefer-dom-node-text-content
✅	unicorn/prefer-event-target
	unicorn/prefer-export-from
✅⏳	unicorn/prefer-global-this
✅⏳	unicorn/prefer-includes
✅	unicorn/prefer-keyboard-event-key
✅⏳	unicorn/prefer-logical-operator-over-ternary
✅	unicorn/prefer-math-min-max
✅⏳	unicorn/prefer-math-trunc
✅⏳	unicorn/prefer-modern-dom-apis
✅⏳	unicorn/prefer-modern-math-apis
	unicorn/prefer-module
✅⏳	unicorn/prefer-native-coercion-functions
✅	unicorn/prefer-negative-index
✅	unicorn/prefer-node-protocol
✅	unicorn/prefer-number-properties
✅⏳	unicorn/prefer-object-from-entries
✅	unicorn/prefer-optional-catch-binding
✅	unicorn/prefer-prototype-methods
✅	unicorn/prefer-query-selector
✅	unicorn/prefer-reflect-apply
✅	unicorn/prefer-regexp-test
✅⏳	unicorn/prefer-response-static-json
✅	unicorn/prefer-set-has
✅	unicorn/prefer-set-size
	unicorn/prefer-single-call
✅	unicorn/prefer-spread
✅	unicorn/prefer-string-raw
✅	unicorn/prefer-string-replace-all
✅	unicorn/prefer-string-slice
✅	unicorn/prefer-string-starts-ends-with
✅	unicorn/prefer-string-trim-start-end
✅	unicorn/prefer-structured-clone
	unicorn/prefer-switch
	unicorn/prefer-ternary
✅	unicorn/prefer-top-level-await
✅	unicorn/prefer-type-error
	unicorn/prevent-abbreviations
	unicorn/relative-url-style
✅	unicorn/require-array-join-separator
✅	unicorn/require-module-attributes
✅	unicorn/require-module-specifiers
✅	unicorn/require-number-to-fixed-digits-argument
✅	unicorn/switch-case-braces
	unicorn/template-indent
✅	unicorn/text-encoding-identifier-case
✅	unicorn/throw-new-error

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

Not recommended rules

✅: 1, 🚫: 0, ⏳: 0 / total: 9

Status	Name
	unicorn/better-regex
	unicorn/consistent-destructuring
	unicorn/custom-error-definition
	unicorn/no-keyword-prefix
	unicorn/no-unused-properties
	unicorn/prefer-import-meta-properties
	unicorn/prefer-json-parse-buffer
✅	unicorn/require-post-message-target-origin
	unicorn/string-content

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

Deprecated rules

✅: 2, 🚫: 1, ⏳: 0 / total: 3

Status	Name
🚫	unicorn/no-array-push-push
✅	unicorn/no-instanceof-array
✅	unicorn/no-length-as-slice-end

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

[Boshen]

Rspack needs https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/filename-case.md

[Thiry1]

Recommended rules

• better-regex
• catch-error-name
• consistent-destructuring
• consistent-function-scoping
• empty-brace-spaces
• error-message
• escape-case
• expiring-todo-comments
• explicit-length-check
• filename-case
• import-style
• new-for-builtins
• no-abusive-eslint-disable
• no-array-callback-reference
• no-array-for-each
• no-array-method-this-argument
• no-array-push-push
• no-array-reduce
• no-await-expression-member
• no-console-spaces
• no-document-cookie
• no-empty-file
• no-for-loop
• no-hex-escape
• no-instanceof-array
• no-invalid-remove-event-listener
• no-lonely-if
• no-negated-condition
• no-nested-ternary
• no-new-array
• no-new-buffer
• no-null
• no-object-as-default-parameter
• no-process-exit
• no-static-only-class
• no-thenable
• no-this-assignment
• no-typeof-undefined
• no-unnecessary-await
• no-unreadable-array-destructuring
• no-unreadable-iife
• no-useless-fallback-in-spread
• no-useless-length-check
• no-useless-promise-resolve-reject
• no-useless-spread
• no-useless-switch-case
• no-useless-undefined
• no-zero-fractions
• number-literal-case
• numeric-separators-style
• prefer-add-event-listener
• prefer-array-find
• prefer-array-flat
• prefer-array-flat-map
• prefer-array-index-of
• prefer-array-some
• prefer-at
• prefer-blob-reading-methods
• prefer-code-point
• prefer-date-now
• prefer-default-parameters
• prefer-dom-node-append
• prefer-dom-node-dataset
• prefer-dom-node-remove
• prefer-dom-node-text-content
• prefer-event-target
• prefer-export-from
• prefer-includes
• prefer-keyboard-event-key
• prefer-logical-operator-over-ternary
• prefer-math-trunc
• prefer-modern-dom-apis
• prefer-modern-math-apis
• prefer-module
• prefer-native-coercion-functions
• prefer-negative-index
• prefer-node-protocol
• prefer-number-properties
• prefer-object-from-entries
• prefer-optional-catch-binding
• prefer-prototype-methods
• prefer-query-selector
• prefer-reflect-apply
• prefer-regexp-test
• prefer-set-has
• prefer-set-size
• prefer-spread
• prefer-string-replace-all
• prefer-string-slice
• prefer-string-starts-ends-with
• prefer-string-trim-start-end
• prefer-switch
• prefer-ternary
• prefer-top-level-await
• prefer-type-error
• prevent-abbreviations
• relative-url-style
• require-array-join-separator
• require-number-to-fixed-digits-argument
• switch-case-braces
• template-indent
• text-encoding-identifier-case
• throw-new-error

[Boshen]

@Thiry1 Thank you! I updated the list.

[Boshen]

There are some convention / style rules, which should be omitted from the list. We should aim for correctness rules.