☂️ typescript-eslint

[Boshen]

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is the tracking issue for @typescript-eslint/eslint-plugin.

There are 66(+ 7 deprecated) rules.

• 0/20 recommended rules are remaining as TODO
  • 1 of which have pending fixes
  • All done! 🎉
• 12/46 not recommended rules are remaining as TODO
  • 4 of which have pending fixes

To get started, run the following command:

just new-typescript-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✅: 20, 🚫: 0, ⏳: 1 / total: 20

Status	Name
✅	typescript/ban-ts-comment
✅	typescript/no-array-constructor
✅	typescript/no-duplicate-enum-values
✅	typescript/no-empty-object-type
✅	typescript/no-explicit-any
✅	typescript/no-extra-non-null-assertion
✅	typescript/no-misused-new
✅	typescript/no-namespace
✅	typescript/no-non-null-asserted-optional-chain
✅⏳	typescript/no-require-imports
✅	typescript/no-this-alias
✅	typescript/no-unnecessary-type-constraint
✅	typescript/no-unsafe-declaration-merging
✅	typescript/no-unsafe-function-type
✅	typescript/no-unused-expressions
✅	typescript/no-unused-vars
✅	typescript/no-wrapper-object-types
✅	typescript/prefer-as-const
✅	typescript/prefer-namespace-keyword
✅	typescript/triple-slash-reference

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

Not recommended rules

✅: 34, 🚫: 0, ⏳: 4 / total: 46

Status	Name
✅	typescript/adjacent-overload-signatures
✅	typescript/array-type
✅	typescript/ban-tslint-comment
	typescript/class-literal-property-style
✅	typescript/class-methods-use-this
✅⏳	typescript/consistent-generic-constructors
✅	typescript/consistent-indexed-object-style
	typescript/consistent-type-assertions
✅	typescript/consistent-type-definitions
✅	typescript/consistent-type-imports
✅	typescript/default-param-last
✅	typescript/explicit-function-return-type
	typescript/explicit-member-accessibility
✅	typescript/explicit-module-boundary-types
✅	typescript/init-declarations
✅	typescript/max-params
	typescript/member-ordering
	typescript/method-signature-style
✅⏳	typescript/no-confusing-non-null-assertion
✅	typescript/no-dupe-class-members
✅	typescript/no-dynamic-delete
✅	typescript/no-empty-function
✅	typescript/no-extraneous-class
✅	typescript/no-import-type-side-effects
✅	typescript/no-inferrable-types
	typescript/no-invalid-this
	typescript/no-invalid-void-type
✅	typescript/no-loop-func
✅⏳	typescript/no-magic-numbers
✅	typescript/no-non-null-asserted-nullish-coalescing
✅	typescript/no-non-null-assertion
✅	typescript/no-redeclare
✅	typescript/no-restricted-imports
✅	typescript/no-restricted-types
	typescript/no-shadow
✅	typescript/no-unnecessary-parameter-property-assignment
	typescript/no-unused-private-class-members
	typescript/no-use-before-define
✅	typescript/no-useless-constructor
✅	typescript/no-useless-empty-export
	typescript/parameter-properties
✅	typescript/prefer-enum-initializers
✅⏳	typescript/prefer-for-of
✅	typescript/prefer-function-type
✅	typescript/prefer-literal-enum-member
	typescript/unified-signatures

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

Deprecated rules

✅: 4, 🚫: 3, ⏳: 0 / total: 7

Status	Name
✅	typescript/no-empty-interface
✅	typescript/no-loss-of-precision
🚫	typescript/no-type-alias
✅	typescript/no-var-requires
✅	typescript/prefer-ts-expect-error
🚫	typescript/sort-type-constituents
🚫	typescript/typedef

✅ = Implemented, 🚫 = No need to implement, ⏳ = Fix pending

[alfaproject]

Will type checking rules be considered for implementation at any point in time?

[alxpsr]

Have checked typescript/member-ordering: not working yet. Just for status

Version: 0.2.6

[happy-turtle]

I looked into typescript/no-confusing-non-null-assertion, but I am not able to run the test. The test code does not seem to be valid JavaScript? Is oxc maybe validating the test's JS code while typescript-eslint is not?

  × Cannot assign to this expression
   ╭─[no_confusing_non_null_assertion.tsx:1:2]
 1 │ (a + b!) = c;
   ·  ──────
   ╰────

[Boshen]

I looked into typescript/no-confusing-non-null-assertion, but I am not able to run the test. The test code does not seem to be valid JavaScript? Is oxc maybe validating the test's JS code while typescript-eslint is not?

  × Cannot assign to this expression
   ╭─[no_confusing_non_null_assertion.tsx:1:2]
 1 │ (a + b!) = c;
   ·  ──────
   ╰────

Just comment out the tests that raise an error.

[todor-a]

Am I missing something or is the await-thenable rule missing from the list?

[Boshen]

Am I missing something or is the await-thenable rule missing form the list?

It seems like we excluded all type checking rules from the recommended-type-checked list.