keyboardActions: Use event.preventDefault only when an action has been found #9559
Conversation
…n found ... and handle multiple registered actions for bound keys
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
We could further simplify this by using https://vueuse.org/core/useEventListener/ |
There was a problem hiding this comment.
LGTM, unit tests are still failing though. @jacob-nv That solves the issue we talked about yesterday regarding the blocked browser shortcuts 🙂
We could further simplify this by using https://vueuse.org/core/useEventListener/
That would be nice, I think there are a lot of other use-cases for this as well.
|
SonarCloud Quality Gate failed.
|
…n found (#9559) * keyboardActions: Use event.preventDefault only when an action has been found ... and handle multiple registered actions for bound keys * Simplify code for event listener addition/removal * Use useEventListener from @vueuse * Fix lint * Register keyboardActions globally to avoid focus issues * Disable shortcut handling in certain contexts
…n found (#9559) * keyboardActions: Use event.preventDefault only when an action has been found ... and handle multiple registered actions for bound keys * Simplify code for event listener addition/removal * Use useEventListener from @vueuse * Fix lint * Register keyboardActions globally to avoid focus issues * Disable shortcut handling in certain contexts
…n found (#9559) * keyboardActions: Use event.preventDefault only when an action has been found ... and handle multiple registered actions for bound keys * Simplify code for event listener addition/removal * Use useEventListener from @vueuse * Fix lint * Register keyboardActions globally to avoid focus issues * Disable shortcut handling in certain contexts
Description
... and handle multiple registered actions for bound keys
Related Issue
Motivation and Context
With
event.preventDefault()at the top of the handler all text input is blockedcc @jacob-nv
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: