Skip to content

Some additions to the README#18

Merged
kulmann merged 4 commits into
mainfrom
readme1
Oct 8, 2024
Merged

Some additions to the README#18
kulmann merged 4 commits into
mainfrom
readme1

Conversation

@dragotin

@dragotin dragotin commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

a few proposals that I think might be helpful

Comment thread README.md Outdated
dragotin and others added 2 commits October 2, 2024 13:02
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Comment thread README.md
> **Note:** The `build:w` script will watch for changes in your files and automatically recompile your app. You can stop the process with `Ctrl+C`.
3. Add `127.0.0.1 host.docker.internal` to your `/etc/hosts` file. We currently only support local development with Docker on Linux and macOS.
4. Start the development server:
In case you see errors about failed commands (such as Command "vite" not found) try to re-run the pnpm command.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? why re-run? I've never seen a case where an actual re-run would be necessary. Maybe a I mistakenly didn't run it at all in the first place... is it that what you are implying? Or do you really mean a re-run?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I actually had to re-run. Well, I just re-run, and after that, my issue was gone. But of course this sentence is not that important.

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the readme improvements! 🥇

@kulmann kulmann merged commit 9a13922 into main Oct 8, 2024
@kulmann kulmann deleted the readme1 branch October 8, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants