Skip to content

Removes aliasing for namespaces that affected maven #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Removes aliasing for namespaces that affected maven #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions depscan/lib/normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,6 @@ def create_pkg_variations(pkg_dict):
vendor_aliases.add(vendor)
vendor_aliases.add(vendor.lower())
vendor_aliases.add(vendor.lstrip("@"))
if (
vendor.startswith("org.")
or vendor.startswith("io.")
or vendor.startswith("com.")
or vendor.startswith("net.")
):
tmp_a = vendor.split(".")
# Automatically add short vendor forms
if len(tmp_a) > 1 and len(tmp_a[1]) > 6:
if tmp_a[1] != name:
vendor_aliases.add(tmp_a[1])
# Add some common vendor aliases
if purl.startswith("pkg:golang") and not name.startswith("go"):
vendor_aliases.add("go")
Expand Down
2 changes: 1 addition & 1 deletion test/test_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_pkg_variations():
pkg_list = create_pkg_variations(
{"vendor": "org.eclipse.foo", "name": "bar", "version": "1.0.0"}
)
assert len(pkg_list) > 1
assert len(pkg_list) == 1
pkg_list = create_pkg_variations(
{
"vendor": "com.fasterxml.jackson.core",
Expand Down
Loading