Skip to content

Conversation

cerrussell
Copy link
Collaborator

@cerrussell cerrussell commented Jun 16, 2023

Closes #12

- BeIsStringTerminated
- BeUnSupportedFunction

- id: Nidhogg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check the indentation here using yamllint?

rules:
- id: BANSHEE
title: Detect Banshee
summary: rootkit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the summary is shown in the table print via the cli. Best to make it a few capitalized words.

@cerrussell cerrussell changed the title Feature/malware Banshee and Nidhogg Annotations Jun 17, 2023
@cerrussell cerrussell marked this pull request as ready for review June 17, 2023 01:03
Copy link
Member

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

@cerrussell cerrussell merged commit db78259 into owasp-dep-scan:feature/malware Jun 17, 2023
cerrussell added a commit that referenced this pull request Jun 17, 2023
* Tweaks

* Tweaks

* Suggest fuzzing option

* Tweaks dictionary

* Improve pe annotations

* Bump version

* Added authz api for PE

* Update packages

* Bug fix

* Bug fix

* Bug fix

* Symbols metadata enhancements

* Use python 3.10

* Package updates

* Package updates

* Package updates

* Bug fix for packed x86_64 executables

* Readme update

* Github actions

* Github actions

* Github actions

* Github actions

* Github actions

* Update packages

* Update packages

* Package updates

Signed-off-by: Prabhu Subramanian <[email protected]>

* Update packages

Signed-off-by: Prabhu Subramanian <[email protected]>

* monero wip

Signed-off-by: Prabhu Subramanian <[email protected]>

* initial commit

* initial commit

* Update project website

* initial commit

Signed-off-by: Caroline Russell <[email protected]>

* Banshee and Nidhogg Annotations (#18)

* initial commit

* Updated summaries and fixed indentation.

* Updated nidhogg ID

---------

Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Caroline Russell <[email protected]>
Co-authored-by: Prabhu Subramanian <[email protected]>
Co-authored-by: Prabhu Subramanian <[email protected]>
Co-authored-by: Prabhu Subramanian <[email protected]>
Co-authored-by: Caroline Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants