Optimize DataLoader::await method
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DataLoader::await` first tries to get the fulfilled value or the rejected reason directly from the promise otherwise calls promise adapter `await` to complete promise. Now `DataLoader::await` will not throw "no active dataLoader instance" exception when Promise entry is null.
mcg-web
force-pushed
the
optimize-await-method
branch
from
1aea60b to
56b0f04
Compare
barduck007
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataLoader::awaitfirst tries to get the fulfilled valueor the rejected reason directly from the promise
otherwise calls promise adapter
awaitto complete promise.
Now
DataLoader::awaitwill not throw "no activedataLoader instance" exception when Promise entry is null.